All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Dario Faggioli <raistlin@linux.it>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Gregory Haskins <ghaskins@novell.com>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Mike Galbraith <efault@gmx.de>,
	Dhaval Giani <dhaval@retis.sssup.it>,
	Fabio Checconi <fabio@gandalf.sssup.it>,
	Darren Hart <darren@dvhart.com>, oleg <oleg@redhat.com>,
	paulmck <paulmck@linux.vnet.ibm.com>,
	pjt@google.com, bharata@linux.vnet.ibm.co,
	lucas.de.marchi@gmail.com
Subject: Re: [RFC][PATCH 0/3] Refactoring sched_entity and sched_rt_entity.
Date: Tue, 04 Jan 2011 20:26:37 +0100	[thread overview]
Message-ID: <1294169197.2016.188.camel@laptop> (raw)
In-Reply-To: <1294164700.6169.197.camel@Palantir>

On Tue, 2011-01-04 at 19:11 +0100, Dario Faggioli wrote:
> > struct task_group {
> > 
> > #ifdef CONFIG_FAIR_GROUP_SCHED
> >       struct sched_entity **cfs_se;
> >       ...
> > #endif
> > 
> > #ifdef CONFIG_RT_GROUP_SCHED
> >       struct sched_entity **rt_se;
> >       ...
> > #endif
> > 
> > }
> > 
> Well, sure this can be done. But what about the common fields? I guess
> you're suggesting to use something like `struct sched_entity_common' and
> putting them there, aren't you?
> 
> If yes, I'm fine with that, although it'll add one more level of
> indirection for those fields (e.g., p->se.comm.on_rq). Are we cool with
> this? 

I'm pretty sure we're mis-understanding each other here, I meant to keep
two complete sched_entity structures (both containing the common/fair/rt
parts). That way, one can use the fair and the other the rt part.

  reply	other threads:[~2011-01-04 19:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 15:55 [RFC][PATCH 0/3] Refactoring sched_entity and sched_rt_entity Dario Faggioli
2011-01-04 16:00 ` [RFC][PATCH 1/3] sched: rename sched_entity to sched_cfs_entity Dario Faggioli
2011-01-04 16:01 ` [RFC][PATCH 2/3] sched: make `struct sched_entity' independent from the scheduling class Dario Faggioli
2011-01-04 16:02 ` [RFC][PATCH 3/3] sched: beautify access to some common fields Dario Faggioli
2011-01-04 16:18 ` [RFC][PATCH 0/3] Refactoring sched_entity and sched_rt_entity Lucas De Marchi
2011-01-04 18:31   ` Dario Faggioli
2011-01-04 16:19 ` Peter Zijlstra
2011-01-04 18:11   ` Dario Faggioli
2011-01-04 19:26     ` Peter Zijlstra [this message]
2011-01-04 16:37 ` Lucas De Marchi
2011-01-04 16:41   ` Peter Zijlstra
2011-01-04 18:08     ` Dario Faggioli
2011-01-04 17:58   ` Dario Faggioli
2011-01-04 18:29     ` Lucas De Marchi
2011-01-04 18:57       ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294169197.2016.188.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=bharata@linux.vnet.ibm.co \
    --cc=darren@dvhart.com \
    --cc=dhaval@retis.sssup.it \
    --cc=efault@gmx.de \
    --cc=fabio@gandalf.sssup.it \
    --cc=ghaskins@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.de.marchi@gmail.com \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pjt@google.com \
    --cc=raistlin@linux.it \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.