From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [RFC patch 5/5] trace event sched: remove TP_perf_assign
Date: Wed, 05 Jan 2011 10:58:06 +0100 [thread overview]
Message-ID: <1294221486.2016.212.camel@laptop> (raw)
In-Reply-To: <20110104232419.782205410@efficios.com>
On Tue, 2011-01-04 at 18:16 -0500, Mathieu Desnoyers wrote:
> plain text document attachment (trace-event-sched-remove-perf-count.patch)
> The TP_perf_assign part of 2 scheduler TRACE_EVENT are not used and don't act as
> TRACE_EVENT fields per se.
Hrm,. they should be used, include/trace/ftrace.h uses __perf_count().
If it doesn't actually work them something broke.
So NAK on removing them.
next prev parent reply other threads:[~2011-01-05 9:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:16 [RFC patch 0/5] Trace event fixes and cleanups Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 1/5] trace event block fix unassigned field Mathieu Desnoyers
2011-01-05 15:09 ` Jeff Moyer
2011-01-05 19:34 ` Mathieu Desnoyers
2011-01-05 19:57 ` Jeff Moyer
2011-01-04 23:16 ` [RFC patch 2/5] trace event skb " Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 3/5] ftrace trace event add missing semicolumn Mathieu Desnoyers
2011-01-05 0:00 ` Frederic Weisbecker
2011-01-05 0:18 ` Mathieu Desnoyers
2011-01-05 2:08 ` Frederic Weisbecker
2011-01-05 2:35 ` Mathieu Desnoyers
2011-01-05 2:58 ` Frederic Weisbecker
2011-01-05 13:52 ` Mathieu Desnoyers
2011-01-05 15:02 ` Frederic Weisbecker
2011-01-05 19:56 ` Mathieu Desnoyers
2011-01-05 23:40 ` Frederic Weisbecker
2011-01-05 23:57 ` Steven Rostedt
2011-01-06 18:08 ` Mathieu Desnoyers
2011-01-05 3:01 ` Valdis.Kletnieks
2011-01-05 3:10 ` Frederic Weisbecker
2011-01-05 6:37 ` Valdis.Kletnieks
2011-01-05 13:56 ` Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 4/5] tracepoint trace event add missing comma Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 5/5] trace event sched: remove TP_perf_assign Mathieu Desnoyers
2011-01-05 9:58 ` Peter Zijlstra [this message]
2011-01-05 13:28 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294221486.2016.212.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.