All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Andrzej Zaborowski <balrog@zabor.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 2/3] tcg/arm: fix qemu_st64 for big endian targets
Date: Thu,  6 Jan 2011 22:54:33 +0100	[thread overview]
Message-ID: <1294350874-6885-2-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1294350874-6885-1-git-send-email-aurelien@aurel32.net>

Due to a typo, qemu_st64 doesn't properly byteswap the 32-bit low word of
a 64 bit word before saving it. This patch fixes that.

Cc: Andrzej Zaborowski <balrog@zabor.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 tcg/arm/tcg-target.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 9def2e5..08c44c1 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -1248,7 +1248,7 @@ static inline void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, int opc)
             tcg_out_bswap32(s, COND_EQ, TCG_REG_R0, data_reg2);
             tcg_out_st32_rwb(s, COND_EQ, TCG_REG_R0, TCG_REG_R1, addr_reg);
             tcg_out_bswap32(s, COND_EQ, TCG_REG_R0, data_reg);
-            tcg_out_st32_12(s, COND_EQ, data_reg, TCG_REG_R1, 4);
+            tcg_out_st32_12(s, COND_EQ, TCG_REG_R0, TCG_REG_R1, 4);
         } else {
             tcg_out_st32_rwb(s, COND_EQ, data_reg, TCG_REG_R1, addr_reg);
             tcg_out_st32_12(s, COND_EQ, data_reg2, TCG_REG_R1, 4);
-- 
1.7.2.3

  reply	other threads:[~2011-01-06 21:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 21:54 [Qemu-devel] [PATCH 1/3] tcg/arm: fix branch target change during code retranslation Aurelien Jarno
2011-01-06 21:54 ` Aurelien Jarno [this message]
2011-01-07 12:37   ` [Qemu-devel] [PATCH 2/3] tcg/arm: fix qemu_st64 for big endian targets andrzej zaborowski
2011-01-06 21:54 ` [Qemu-devel] [PATCH 3/3] tcg/arm: improve constant loading Aurelien Jarno
2011-01-07 12:52   ` andrzej zaborowski
2011-01-07 12:55     ` andrzej zaborowski
2011-01-07 14:40     ` Aurelien Jarno
2011-01-07 15:56       ` andrzej zaborowski
2011-01-09 22:40         ` Aurelien Jarno
2011-01-09 23:33           ` andrzej zaborowski
2011-01-10  3:41             ` Peter Maydell
2011-01-07  9:12 ` [Qemu-devel] [PATCH 1/3] tcg/arm: fix branch target change during code retranslation Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294350874-6885-2-git-send-email-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=balrog@zabor.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.