From: Ben Hutchings <bhutchings@solarflare.com>
To: christoph.paasch@uclouvain.be
Cc: Randy Dunlap <rdunlap@xenotime.net>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cleanup include/net/tcp.h include-files and coding-style
Date: Sun, 09 Jan 2011 23:06:29 +0000 [thread overview]
Message-ID: <1294614389.2823.35.camel@localhost> (raw)
In-Reply-To: <201101092333.19406.christoph.paasch@uclouvain.be>
On Sun, 2011-01-09 at 23:33 +0100, Christoph Paasch wrote:
> On Sunday, January 09, 2011 wrote Ben Hutchings:
> > The cost of repeated inclusion is minimal. GCC's preprocessor
> > recognises when the entire content of a file is conditional on #ifndef
> > FOO and will not even open it again if FOO is defined.
> Thanks, I did not knew about that.
>
> > If a file directly references definitions that are supposed to be
> > provided by a certain header, changing it to rely on indirect inclusion
> > of that header generally does *not* aid maintenance.
> But then, to be coherent, we would need to add the following includes (and I'm
> even not 100% sure if it's all we need):
>
> linux/percpu_counter.h (needed for percpu_counter_sum_positive)
Yes.
> linux/mm_types.h (needed for struct page)
> linux/aio.h (needed for struct kiocb)
> net/inet_sock.h (needed for struct ip_options)
> linux/pipe_fs_i.h (needed for struct pipe_inode_info)
> linux/poll.h (needed for struct poll_table_struct)
Or declarations of those structs.
> linux/compiler.h (needed for __percpu)
[...]
Yes.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-01-09 23:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 20:55 [PATCH] Cleanup include/net/tcp.h include-files and coding-style Christoph Paasch
2011-01-09 21:06 ` Randy Dunlap
2011-01-09 21:32 ` Christoph Paasch
2011-01-09 21:55 ` Ben Hutchings
2011-01-09 22:33 ` Christoph Paasch
2011-01-09 23:06 ` Ben Hutchings [this message]
2011-01-10 9:03 ` Christoph Paasch
2011-01-10 11:11 ` Alexey Dobriyan
2011-01-10 11:44 ` Christoph Paasch
2011-01-10 12:12 ` Alexey Dobriyan
2011-01-10 15:50 ` Randy Dunlap
2011-01-10 16:24 ` Christoph Paasch
2011-01-10 16:30 ` Randy Dunlap
2011-01-10 17:02 ` Alexey Dobriyan
2011-01-09 22:30 ` Alexey Dobriyan
2011-01-09 22:39 ` Christoph Paasch
2011-01-09 23:06 ` Christoph Paasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294614389.2823.35.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.