From: Joe Perches <joe@perches.com>
To: ahern.michael.t@gmail.com
Cc: gregkh@suse.de, u.kleine-koenig@pengutronix.de, julia@diku.dk,
nikai@nikai.net, morgan.gatti@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] Coding style in serial2002 Patch that resolves braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern
Date: Sun, 09 Jan 2011 15:56:05 -0800 [thread overview]
Message-ID: <1294617365.7495.193.camel@Joe-Laptop> (raw)
In-Reply-To: <1294614196-6665-4-git-send-email-ahern.michael.t@gmail.com>
On Mon, 2011-01-10 at 10:03 +1100, ahern.michael.t@gmail.com wrote:
> From: mah <ahern.michael.t@gmail.com>
Hi Michael, just trivia.
> drivers/staging/comedi/drivers/serial2002.c | 206 ++++++++++++---------------
> @@ -451,23 +454,23 @@ static int serial_2002_open(struct comedi_device *dev)
> command = (data.value >> 8) & 0x3;
> switch (kind) {
> case 1:{
> - cur_config = dig_in_config;
> + cur_config = dig_in_config;
> }
> break;
> case 2:{
You could remove the braces from all the case labels as well.
[]
> + switch (unit) {
> + case 0:{
> + min = min * 1000000;
Perhaps *= 1000000 and *= 1000
next prev parent reply other threads:[~2011-01-09 23:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 23:03 [PATCH 1/5] Staging: comedi: fix line-length coding style issue in usbduxfast.c ahern.michael.t
2011-01-09 23:03 ` [PATCH 2/5] Staging: comedi: whitespace ahern.michael.t
2011-01-09 23:03 ` [PATCH 3/5] Coding style in unioxx5.c KERN_ facility level and coding style warnings as reported by checkpatch.pl Signed-off-by: Michael Ahern <ahern.michael.t@gmail.com> ahern.michael.t
2011-01-10 6:39 ` Greg KH
2011-01-09 23:03 ` [PATCH 4/5] Coding style in serial2002 Patch that resolves braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern ahern.michael.t
2011-01-09 23:56 ` Joe Perches [this message]
2011-01-09 23:03 ` [PATCH 5/5] Coding style in s626 Patch that resolves line length warnings by checkpatch.pl Signed-off-by: Michael Ahern <ahern.michael.t@gmail.com> ahern.michael.t
2011-01-10 6:39 ` Greg KH
2011-01-10 6:36 ` [PATCH 1/5] Staging: comedi: fix line-length coding style issue in usbduxfast.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294617365.7495.193.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ahern.michael.t@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=morgan.gatti@gmail.com \
--cc=nikai@nikai.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.