All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Mike Galbraith <efault@gmx.de>
Cc: bharata@linux.vnet.ibm.com, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] Re: autogroup: sched_setscheduler() fails
Date: Mon, 10 Jan 2011 11:59:14 +0100	[thread overview]
Message-ID: <1294657154.2016.459.camel@laptop> (raw)
In-Reply-To: <1294655388.8197.22.camel@marge.simson.net>

On Mon, 2011-01-10 at 11:29 +0100, Mike Galbraith wrote:
> 
> Right, autogroup should be excluding CONFIG_RT_GROUP_SCHED, since it
> doesn't currently support it.
> 
> sched: SCHED_AUTOGROUP selection excludes RT_GROUP_SCHED
> 
> Autogroup does not support realtime task groups, so make selection of
> SCHED_AUTOGROUP exclude RT_GROUP_SCHED.
> 
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Reported-by:Bharata B Rao <bharata@linux.vnet.ibm.com>
> 
> ---
>  init/Kconfig |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> Index: linux-2.6/init/Kconfig
> ===================================================================
> --- linux-2.6.orig/init/Kconfig
> +++ linux-2.6/init/Kconfig
> @@ -699,6 +699,7 @@ config RT_GROUP_SCHED
>         bool "Group scheduling for SCHED_RR/FIFO"
>         depends on EXPERIMENTAL
>         depends on CGROUP_SCHED
> +       depends on !SCHED_AUTOGROUP
>         default n
>         help
>           This feature lets you explicitly allocate real CPU bandwidth
> @@ -807,6 +808,10 @@ config SCHED_AUTOGROUP
>           desktop applications.  Task group autogeneration is currently based
>           upon task session.
>  
> +         Note: SCHED_AUTOGROUP does not support realtime tasks, and prevents
> +         enabling RT_GROUP_SCHED.  If you intend to use group scheduling for
> +         realtime tasks, do not enable this option.
> +
>  config MM_OWNER
>         bool
>   

Uhm, no. The right way is to put tasks back into the root group and then
perform sched_setscheduler().

  reply	other threads:[~2011-01-10 10:58 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10  9:16 autogroup: sched_setscheduler() fails Bharata B Rao
2011-01-10 10:29 ` [patch] " Mike Galbraith
2011-01-10 10:59   ` Peter Zijlstra [this message]
2011-01-10 16:42     ` Mike Galbraith
2011-01-11 17:10       ` Bharata B Rao
2011-01-11 18:48         ` Mike Galbraith
2011-01-12  3:37           ` Bharata B Rao
2011-01-12  5:40             ` Yong Zhang
2011-01-12  6:35               ` Bharata B Rao
2011-01-12  7:24                 ` Mike Galbraith
2011-01-12  8:06                   ` Bharata B Rao
2011-01-12  8:47                     ` Mike Galbraith
2011-01-12  9:26                       ` Bharata B Rao
2011-01-12  6:17             ` Mike Galbraith
2011-01-12  6:42               ` Bharata B Rao
2011-01-12  5:40           ` Mike Galbraith
2011-01-12  6:32             ` Yong Zhang
2011-01-12  8:55               ` Mike Galbraith
2011-01-13  3:54               ` Mike Galbraith
2011-01-13  5:59                 ` Yong Zhang
2011-01-13  6:02                   ` Yong Zhang
2011-01-13  6:13                   ` Mike Galbraith
2011-01-13  8:46                 ` Bharata B Rao
2011-01-17 13:16                 ` Peter Zijlstra
2011-02-15 15:46                   ` torbenh
2011-02-15 16:43                     ` Mike Galbraith
2011-02-18 11:09                       ` torbenh
2011-02-18 12:50                         ` Mike Galbraith
2011-02-18 13:40                           ` torbenh
2011-02-22 12:24                           ` torbenh
2011-02-22 14:47                             ` Mike Galbraith
2011-02-28 17:53                               ` torbenh
2011-02-28 18:29                                 ` Mike Galbraith
2011-02-28 19:10                                   ` torbenh
2011-03-01  4:02                                     ` Mike Galbraith
2011-03-01  4:21                                       ` Mike Galbraith
2011-03-01 15:59                                         ` torbenh
2011-01-18 19:05                 ` [tip:sched/urgent] sched, autogroup: Fix CONFIG_RT_GROUP_SCHED sched_setscheduler() failure tip-bot for Mike Galbraith
2011-01-12  5:43       ` [patch] Re: autogroup: sched_setscheduler() fails Yong Zhang
2011-01-12  6:25         ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294657154.2016.459.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.