From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Timur Tabi <timur@freescale.com>
Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] [v2] ASoC: let snd_soc_update_bits() return an error code
Date: Tue, 11 Jan 2011 10:51:21 +0000 [thread overview]
Message-ID: <1294743081.3338.0.camel@odin> (raw)
In-Reply-To: <1294696693-4602-1-git-send-email-timur@freescale.com>
On Mon, 2011-01-10 at 15:58 -0600, Timur Tabi wrote:
> Update snd_soc_update_bits() so that it returns a negative error code if the
> the read or write operation fails.
>
> Note that currently, a lot of the lower-level read functions have an unsigned
> integer return type (and some of them even try to return a negative number),
> but this code still appears to work in those cases.
>
> An examination of the code shows that all current callers are compatible with
> this change.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-01-11 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 21:58 [PATCH] [v2] ASoC: let snd_soc_update_bits() return an error code Timur Tabi
2011-01-11 10:51 ` Liam Girdwood [this message]
2011-01-11 11:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294743081.3338.0.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.