Re: [PATCHv5] plugin: Add ste modem initd integration

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

Hi Denis,

> >>> so these are declared as get_modems(void) btw. The compiler should have
> >>> warned you about this.
> >>
> >> I don't get a compiler warning for this one, not even with -Wall
> >> -Wextra -Wpedantic on GCC 4.4.3.
> >> But a new rule in the coding-style should perhaps be added, e.g:
> >>
> >> M15: Use void if function has no parameters
> >> ====================================
> >> A function with no parameters must use void in the parameter list.
> >> Example:
> >> 1)
> >> void foo(void)
> >> {
> >> }
> >>
> >> 2)
> >> void foo()	// Wrong
> >> {
> >> }
> > 
> > please go ahead and send a patch for this. I am happily adding it.
> > 
> 
> Sorry I'm not following why this is a good idea?

we have always declared functions with no parameters as (void) and not
as (). At least I have.

Regards

Marcel