Re: [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

Hi Jeevaka,

>  include/voicecall.h |    2 ++
>  src/voicecall.c     |   12 ++++++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/include/voicecall.h b/include/voicecall.h
> index e37d73b..6f1bdd2 100644
> --- a/include/voicecall.h
> +++ b/include/voicecall.h
> @@ -144,6 +144,8 @@ void ofono_voicecall_notify(struct ofono_voicecall *vc,
>  void ofono_voicecall_disconnected(struct ofono_voicecall *vc, int id,
>  				enum ofono_disconnect_reason reason,
>  				const struct ofono_error *error);
> +void ofono_voicecall_tty_notify(struct ofono_voicecall *vc,
> +				const struct ofono_call *call);

what is the advantage of having this separate and not part of the
regular voicecall_notify and just extending struct ofono_call with a
field for TTY?

Regards

Marcel