From: jamal <hadi@cyberus.ca>
To: Vlad Dogaru <ddvlad@rosedu.org>
Cc: netdev@vger.kernel.org, Octavian Purdila <opurdila@ixiacom.com>
Subject: Re: [PATCH v2 2/2] netlink: support setting devgroup parameters
Date: Wed, 12 Jan 2011 10:44:02 -0500 [thread overview]
Message-ID: <1294847042.2129.7.camel@mojatatu> (raw)
In-Reply-To: <1294763724-9927-3-git-send-email-ddvlad@rosedu.org>
On Tue, 2011-01-11 at 18:35 +0200, Vlad Dogaru wrote:
> If a rtnetlink request specifies a negative or zero ifindex and has no
> interface name attribute, but has a group attribute, then the chenges
> are made to all the interfaces belonging to the specified group.
>
> Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>
Looks good. Please just do some basic tests like setting a few
interfaces to the same group, changing their MTU and setting admin
up then down. If it works add my ACKed-by on both patches.
The only thing that will still generate a lot of noise is the netlink
events that will be generated afterwards for each change on a netdev in
a group i.e a single netlink message..
Maybe we could batch those in a future patch
cheers,
jamal
prev parent reply other threads:[~2011-01-12 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 16:35 [PATCH v2 0/2] net: add device groups Vlad Dogaru
2011-01-11 16:35 ` [PATCH v2 1/2] net_device: add support for network " Vlad Dogaru
2011-01-12 15:40 ` jamal
2011-01-11 16:35 ` [PATCH v2 2/2] netlink: support setting devgroup parameters Vlad Dogaru
2011-01-12 15:44 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294847042.2129.7.camel@mojatatu \
--to=hadi@cyberus.ca \
--cc=ddvlad@rosedu.org \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.