From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback
Date: Wed, 12 Jan 2011 08:13:26 -0800 [thread overview]
Message-ID: <1294848806.3873.81.camel@aeonflux> (raw)
In-Reply-To: <1294839942-9071-1-git-send-email-tomasz.gregorek@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Hi Tomasz,
> Combining mbm_disable and reopen_callback into one and removing 1 second
> delay between them to avoid call to reopen_callback after modem being
> disconnected.
have you actually tested this? This will not work since you can not
reopen the TTY right away. You need that delay in between.
From my previous email, I remember saying that the right fix would be to
disarm the timer within disable. Why are we not doing that?
Regards
Marcel
next prev parent reply other threads:[~2011-01-12 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 13:45 [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback Tomasz Gregorek
2011-01-12 16:13 ` Marcel Holtmann [this message]
2011-01-12 17:26 ` Tomasz Gregorek
2011-01-12 17:31 ` Marcel Holtmann
2011-01-12 17:42 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-12 17:50 ` Tomasz Gregorek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294848806.3873.81.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.