RE: [PATCH 2/2] ifxmodem: add enable/disable ctm support

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Hi Jeevaka,

> > Now this is something I don't like at all. It is copied code from the
> > modem plugin. 
> 
> Its the same audio configuration code except that there is a new
> parameter added
> at the end of the parameter list for TTY case.

I really hate duplicating magic numbers in two places. Can we do this
without +XDRV for now and put a /* TODO mark */ in the code. I do need
to think about this audio settings handling a bit more.

So you might have to keep the +XDRV local in your code for testing, but
I'd rather get the other TTY logic in place and worry about the audio
stuff in a second round of patches.

> > Also if this is required, we might need to figure out a
> > complete different way of handling this. We can't have this
> > in two places since that means a full disconnect. Maybe
> > putting this into the audio settings atom might be better.
> > However before we can do anything, I have to understand the
> > semantics behind XDRV, normal voice calls and TTY calls.
> > 
> 
> Correct me if I'm wrong. If we move this to the audio settings atom,
> then I'm
> afraid that it will end up in used by only ifx modem. 

I am not following. This whole stuff is IFX specific. So yes, it will
only be used by IFX. All other vendors have to do their own stuff.

Regards

Marcel