From: Ian Kent <raven@themaw.net>
To: Nick Piggin <npiggin@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
aelder@sgi.com, Nick Piggin <npiggin@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [announce] vfs-scale git tree update
Date: Thu, 13 Jan 2011 09:48:33 +0800 [thread overview]
Message-ID: <1294883313.2757.5.camel@perseus> (raw)
In-Reply-To: <AANLkTikYErmu6bNz51iPgjzdOoa8uWNNdn01texihqM6@mail.gmail.com>
On Thu, 2011-01-13 at 12:01 +1100, Nick Piggin wrote:
> On Wed, Jan 12, 2011 at 4:17 PM, Ian Kent <raven@themaw.net> wrote:
> > On Wed, 2011-01-12 at 12:41 +0800, Ian Kent wrote:
> >> On Tue, 2011-01-11 at 20:06 -0800, Linus Torvalds wrote:
> >> > On Tue, Jan 11, 2011 at 7:59 PM, Ian Kent <raven@themaw.net> wrote:
>
> >> > > Yeah, a hangover from changes done over time.
> >> > > Not setting the dentry op in ->lookup() should fix this.
> >> >
> >> > Alex, care to test just removing the d_set_d_op() call from autofs4_lookup()?
> >> >
> >> > (That code is a bit scary, though - it explicitly makes it a negative
> >> > dentry with a d_instantiate(dentry, NULL), and then hides the inode
> >> > information away separately. Scary scary)
> >>
> >> Yeah, but the expire to mount races with autofs are difficult to handle
> >> and this approach has worked well under heavy stress testing. It's true
> >> that this would almost certainly be bad for a file system that supported
> >> a full range of functionality but that's not so for autofs.
> >
> > I think I have to partly take this back.
> > With Nick's recent vfs-scale patches this may not be OK any more since
> > the dcache_lock has gone away and, at first glance, it looks like the
> > added autofs4_lock spin lock doesn't provide the needed protection.
>
> Hm, what are the concurrencies that you need protection from?
Ha, I think I'm wrong about this, after looking more closely at this I'm
struggling to see why autofs4_lock is needed at all.
next prev parent reply other threads:[~2011-01-13 1:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 7:58 [announce] vfs-scale git tree update Nick Piggin
2011-01-11 16:34 ` Alex Elder
2011-01-11 16:51 ` Linus Torvalds
2011-01-11 17:57 ` Alex Elder
2011-01-11 18:13 ` Linus Torvalds
2011-01-11 18:13 ` Linus Torvalds
2011-01-12 3:55 ` Nick Piggin
2011-01-12 3:55 ` Nick Piggin
2011-01-12 3:59 ` Ian Kent
2011-01-12 4:06 ` Nick Piggin
2011-01-12 4:06 ` Linus Torvalds
2011-01-12 4:06 ` Linus Torvalds
2011-01-12 4:41 ` Ian Kent
2011-01-12 5:17 ` Ian Kent
2011-01-13 1:01 ` Nick Piggin
2011-01-13 1:48 ` Ian Kent [this message]
2011-01-13 2:14 ` Nick Piggin
2011-01-13 3:20 ` Ian Kent
2011-01-13 3:22 ` Nick Piggin
2011-01-12 4:15 ` Ian Kent
2011-01-12 20:11 ` Alex Elder
2011-01-13 2:23 ` Ian Kent
2011-01-13 3:03 ` Ian Kent
2011-01-13 17:09 ` Alex Elder
2011-01-12 4:49 ` Aneesh Kumar K. V
2011-01-12 5:01 ` Ian Kent
2011-01-13 0:58 ` Nick Piggin
2011-01-13 1:46 ` Ian Kent
-- strict thread matches above, loose matches on Subject: below --
2011-01-05 10:25 Nick Piggin
2011-01-05 21:00 ` Anca Emanuel
2011-01-06 2:12 ` Jongman Heo
2011-01-07 0:09 ` Nick Piggin
2011-01-07 0:59 ` Chris Ball
2011-01-07 1:41 ` Linus Torvalds
2011-01-07 2:03 ` Chris Ball
2010-12-22 9:53 Nick Piggin
2010-12-22 10:22 ` Sedat Dilek
2010-12-22 10:38 ` Sedat Dilek
2010-12-22 10:38 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294883313.2757.5.camel@perseus \
--to=raven@themaw.net \
--cc=aelder@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=npiggin@kernel.dk \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.