From: Joe Perches <joe@perches.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: David Miller <davem@davemloft.net>,
cmetcalf@tilera.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] etherdevice.h: Add is_unicast_ether_addr function
Date: Thu, 13 Jan 2011 00:43:15 -0800 [thread overview]
Message-ID: <1294908195.4114.43.camel@Joe-Laptop> (raw)
In-Reply-To: <20110113083519.GW29757@distanz.ch>
On Thu, 2011-01-13 at 09:35 +0100, Tobias Klauser wrote:
> On 2011-01-13 at 09:24:41 +0100, Joe Perches <joe@perches.com> wrote:
> I added is_unicast_ether_addr to make the intention of checking for a
> unicast address clearer (see [1] for context).
> [1] http://article.gmane.org/gmane.linux.network/183615
> > I can't think of much reason that a new function for
> > !multicast without the !is_zero is needed.
> Maybe I should just add something like the following?
> #define is_unicast_ether_addr(addr) is_valid_ether_addr(addr)
Adding the #define makes a bit more sense to me.
next prev parent reply other threads:[~2011-01-13 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 9:31 [PATCH net-next-2.6] netdev: tilepro: Use is_multicast_ether_addr helper Tobias Klauser
2011-01-12 17:49 ` Chris Metcalf
2011-01-13 2:45 ` David Miller
2011-01-13 6:58 ` Tobias Klauser
2011-01-13 7:42 ` David Miller
2011-01-13 8:13 ` Tobias Klauser
2011-01-13 8:14 ` [PATCH net-next-2.6] etherdevice.h: Add is_unicast_ether_addr function Tobias Klauser
2011-01-13 8:24 ` Joe Perches
2011-01-13 8:35 ` Tobias Klauser
2011-01-13 8:43 ` Joe Perches [this message]
2011-01-13 8:55 ` Eric Dumazet
2011-01-13 16:38 ` Chris Metcalf
2011-01-13 20:35 ` David Miller
2011-01-14 5:51 ` David Miller
2011-01-13 8:15 ` [PATCH v2 net-next-2.6] netdev: tilepro: Use is_unicast_ether_addr helper Tobias Klauser
2011-01-14 5:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294908195.4114.43.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.