From: Alex Williamson <alex.williamson@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: kwolf@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup
Date: Mon, 17 Jan 2011 10:07:59 -0700 [thread overview]
Message-ID: <1295284079.3216.36.camel@x201> (raw)
In-Reply-To: <1295277867.3216.16.camel@x201>
On Mon, 2011-01-17 at 08:24 -0700, Alex Williamson wrote:
> On Mon, 2011-01-17 at 16:14 +0100, Jes.Sorensen@redhat.com wrote:
> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >
> > Fix issue with signed char and isspace() as well as clean up switch
> > statement using toupper().
> >
> > V2 of the patch fixes some types in the commit messages and spells
> > Eric correctly. My apologies for getting it wrong.
> >
> > Jes Sorensen (2):
> > strtosz() use unsigned char as isspace() is not defined for signed
> > char
> > strtosz() use toupper() to simplify switch statement
> >
> > cutils.c | 10 +++-------
> > 1 files changed, 3 insertions(+), 7 deletions(-)
> >
>
> And the modf() usage? Or using STRTOSZ_DEFSUFFIX_* in the switch? Or
> avoiding the extra variable in 13/18? Thanks,
Sorry, I'm crossing my mailing lists. These are a fine first step.
Acked-by: Alex Williamson <alex.williamson@redhat.com>
prev parent reply other threads:[~2011-01-17 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 15:14 [Qemu-devel] [PATCH v2 0/2] strtosz() cleanup Jes.Sorensen
2011-01-17 15:14 ` [Qemu-devel] [PATCH 1/2] strtosz() use unsigned char as isspace() is not defined for signed char Jes.Sorensen
2011-01-17 19:59 ` Blue Swirl
2011-01-17 15:14 ` [Qemu-devel] [PATCH 2/2] strtosz() use toupper() to simplify switch statement Jes.Sorensen
2011-01-17 19:57 ` Blue Swirl
2011-01-17 15:24 ` [Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup Alex Williamson
2011-01-17 17:07 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295284079.3216.36.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.