From: Johannes Berg <johannes@sipsolutions.net>
To: Bernhard Schmidt <bernhard.schmidt@saxnet.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
lrodriguez@atheros.com, nbd@openwrt.org, dubowoj@neratec.com,
zefir.kurtisi@neratec.com, simon.wunderlich@saxnet.de
Subject: Re: [PATCH 4/5] mac80211: add primarily CAC support
Date: Tue, 18 Jan 2011 13:12:20 +0100 [thread overview]
Message-ID: <1295352740.3563.14.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201101181301.45021.bernhard.schmidt@saxnet.de>
On Tue, 2011-01-18 at 13:01 +0100, Bernhard Schmidt wrote:
> > > + mutex_lock(&radar->mtx);
> >
> > Clearly, you haven't even tested this code. I'm not sure why I'm even
> > reviewing it.
>
> Granted, I did only some basic tests with only a few predefined
> scenarios, not at all is just wrong. Anyways, I should have mentioned in
> 0/13 that preventing channel changes while in CAC should be considered
> and chan should be assigned to local variable then.
I was more referring to the fact that you're trying to lock a mutex in a
timer -- so you can't have executed this code path ever?!
johannes
next prev parent reply other threads:[~2011-01-18 12:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 15:21 [RFC 0/13] DFS/radar state/userspace handling Bernhard Schmidt
2011-01-17 8:31 ` [PATCH 1/5] mac80211: add DFS related channel flags Bernhard Schmidt
2011-01-18 10:40 ` Johannes Berg
2011-01-18 11:59 ` Bernhard Schmidt
2011-01-18 12:16 ` Johannes Berg
2011-01-18 12:27 ` Bernhard Schmidt
2011-01-18 14:29 ` Zefir Kurtisi
2011-01-18 10:40 ` Johannes Berg
2011-01-17 9:16 ` [PATCH 2/5] mac80211: initialize radar params + add driver API Bernhard Schmidt
2011-01-18 10:43 ` Johannes Berg
2011-01-18 12:00 ` Bernhard Schmidt
2011-01-18 10:44 ` Johannes Berg
2011-01-17 10:05 ` [PATCH 3/5] mac80211: add NOL functionality Bernhard Schmidt
2011-01-18 10:43 ` Johannes Berg
2011-01-18 12:01 ` Bernhard Schmidt
2011-01-18 12:13 ` Johannes Berg
2011-01-18 12:28 ` Bernhard Schmidt
2011-01-17 10:24 ` [PATCH 4/5] mac80211: add primarily CAC support Bernhard Schmidt
2011-01-18 10:45 ` Johannes Berg
2011-01-18 12:01 ` Bernhard Schmidt
2011-01-18 12:12 ` Johannes Berg [this message]
2011-01-18 12:28 ` Bernhard Schmidt
2011-01-18 10:48 ` Johannes Berg
2011-01-18 12:00 ` Bernhard Schmidt
2011-01-17 11:49 ` [PATCH 5/5] cfg80211: userspace commands/notifications Bernhard Schmidt
2011-01-17 12:55 ` [PATCH 1/8] hostap: make hostapd_parse_rates generic Bernhard Schmidt
2011-01-17 12:56 ` [PATCH 2/8] hostap: add channel_list config parameter Bernhard Schmidt
2011-01-17 13:00 ` [PATCH 3/8] hostapd: select random channel of the list Bernhard Schmidt
2011-01-17 13:07 ` [PATCH 4/8] hostap: sync nl80211_copy.h Bernhard Schmidt
2011-01-17 13:14 ` [PATCH 5/8] hostap: pull in additional chan flags Bernhard Schmidt
2011-01-17 13:23 ` [PATCH 6/8] hostap: request CAC before using a radar channel Bernhard Schmidt
2011-01-17 13:26 ` [PATCH 7/8] hostap: handle interference on current channel Bernhard Schmidt
2011-01-17 13:27 ` [PATCH 8/8] hostap: do not disable radar channels Bernhard Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295352740.3563.14.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bernhard.schmidt@saxnet.de \
--cc=dubowoj@neratec.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
--cc=simon.wunderlich@saxnet.de \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.