From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] simutil: M9, M11, Minor style fixes and indentation
Date: Tue, 18 Jan 2011 15:17:52 +0100 [thread overview]
Message-ID: <1295360272.3873.172.camel@aeonflux> (raw)
In-Reply-To: <1295353930-25914-1-git-send-email-jessica.j.nilsson@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Hi Jessica,
<snip>
> enum ber_tlv_data_type ber_tlv_iter_get_class(struct ber_tlv_iter *iter);
> -enum ber_tlv_data_encoding_type
> - ber_tlv_iter_get_encoding(struct ber_tlv_iter *iter);
> +enum ber_tlv_data_encoding_type ber_tlv_iter_get_encoding(
> + struct ber_tlv_iter *iter);
leave this one out. It is such a rare corner case with return parameter
being an enum and a long function name. There is really no unique right
way to make this look good. Whatever you try the break will be ugly.
Regards
Marcel
next prev parent reply other threads:[~2011-01-18 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 12:32 [PATCH 1/2] simutil: M9, M11, Minor style fixes and indentation Jessica Nilsson
2011-01-18 14:17 ` Marcel Holtmann [this message]
2011-01-18 15:50 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295360272.3873.172.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.