From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v3] gatserver: ATS6 command handler added
Date: Tue, 18 Jan 2011 16:11:50 +0100 [thread overview]
Message-ID: <1295363510.3873.205.camel@aeonflux> (raw)
In-Reply-To: <1295263138-13265-1-git-send-email-olivier.guiter@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
Hi Olivier,
> Use integer to be compliant with existing function prototypes.
patch has been applied, but I did remove this comment from the commit
message. If you see it within git log it made no sense and was only
relevant for the review.
> ---
So such a comment for review belongs between --- and the diffstat.
> gatchat/gatserver.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
Regards
Marcel
prev parent reply other threads:[~2011-01-18 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 11:18 [PATCH v3] gatserver: ATS6 command handler added Olivier Guiter
2011-01-18 15:11 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295363510.3873.205.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.