All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] Allow distcheck to work without bluetooth
Date: Wed, 19 Jan 2011 14:20:58 +0100	[thread overview]
Message-ID: <1295443258.3873.243.camel@aeonflux> (raw)
In-Reply-To: <1295433065-26502-1-git-send-email-remi.denis-courmont@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi Remi,

> diff --git a/Makefile.am b/Makefile.am
> index c1c34ca..e93076a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@
>  
> 
>  DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles
> +if !BLUETOOTH
> +DISTCHECK_CONFIGURE_FLAGS += --disable-bluetooth
> +endif

this patch makes no sense to me. I am not going to apply it. Using make
distcheck works nicely on my system where I build the releases.

Regards

Marcel



  reply	other threads:[~2011-01-19 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 10:31 [PATCH 2/2] Allow distcheck to work without bluetooth =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-19 13:20 ` Marcel Holtmann [this message]
2011-01-19 13:29   ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-19 14:36     ` Marcel Holtmann
2011-01-20  8:25       ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-20  9:31         ` Marcel Holtmann
2011-01-20  9:52           ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295443258.3873.243.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.