From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: Liuwenyi <qingshenlwy@gmail.com>, strongzgy <strongzgy@gmail.com>,
onlyflyer <onlyflyer@gmail.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
ak <ak@linux.intel.com>, akpm <akpm@linux-foundation.org>,
miaox <miaox@cn.fujitsu.com>,
Yang Ruirui <ruirui.r.yang@tieto.com>,
meego-kernel <meego-kernel@meego.com>
Subject: Re: [PATCH] Avoid a NULL pointer in btrfs
Date: Wed, 19 Jan 2011 10:52:16 -0500 [thread overview]
Message-ID: <1295452288-sup-8924@think> (raw)
In-Reply-To: <20110119141334.GA2544@localhost.localdomain>
Excerpts from Josef Bacik's message of 2011-01-19 09:14:02 -0500:
> On Wed, Jan 19, 2011 at 10:08:13PM +0800, Liuwenyi wrote:
> > In Yang Ruirui's mail, the btrfs will create a oops. This is caused by a
> > null pointer in test_range_bit() while lock the spinlock.
> >
> > So, It is necessary to add a pointer check into test_range_bit()
> >
>
>
> NAK, the tree shouldn't be null coming into this function, something else is
> going wrong. What oops is this? Thanks,
What was your metadata blocksize for this oops? This call should never
happen.
I think there is a larger problem, probably in the IO error handling
code since the trace had io errors beforehand.
-chris
next prev parent reply other threads:[~2011-01-19 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 14:08 [PATCH] Avoid a NULL pointer in btrfs Liuwenyi
2011-01-19 14:08 ` Liuwenyi
2011-01-19 14:14 ` Josef Bacik
2011-01-19 15:52 ` Chris Mason [this message]
2011-01-20 12:26 ` Liuwenyi
2011-01-20 12:26 ` Liuwenyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295452288-sup-8924@think \
--to=chris.mason@oracle.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@meego.com \
--cc=miaox@cn.fujitsu.com \
--cc=onlyflyer@gmail.com \
--cc=qingshenlwy@gmail.com \
--cc=ruirui.r.yang@tieto.com \
--cc=strongzgy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.