From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Scott Garman <scott.a.garman@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/9] libtool: changes to enable sysroot support
Date: Wed, 19 Jan 2011 16:05:51 +0000 [thread overview]
Message-ID: <1295453151.14388.22265.camel@rex> (raw)
In-Reply-To: <1295448538.14388.22027.camel@rex>
On Wed, 2011-01-19 at 14:48 +0000, Richard Purdie wrote:
> On Tue, 2011-01-18 at 20:19 -0800, Scott Garman wrote:
> > * Added OE patches by Khem Raj which enable sysroot support
> > and rename the command line option --with-sysroot to
> > --with-libtool-sysroot to avoid conflicts with binutils and
> > gcc
> > * Stage the -cross and -native libtool in the same relative path
> > so it can be accessed equally well from recipes using
> > BBCLASSEXTEND = "native"
> > * Removed obsolete cross_compile.patch
> > * Reorganized common things to libtool.inc
> > * Changed SRC_URI_append to SRC_URI +=
> > * PR bump for all recipes
>
> I'm afraid this patch has too many changes rolled into one. Not all of
> these changes are sysroot related.
In the interests of moving this forward quickly, I've put together:
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rpurdie/libtool
which is this patch split out into three with some ideas/improvements
from me on the layout.
Your nativesdk PACKAGES change is wrong, the correct fix is to call
libltdl libltdl-nativesdk in the nativesdk case. The simplest way is:
PKGSUFFIX = ""
PACKAGES = "libltdl${PKGSUFFIX}"
and then change PKGSUFFIX in the nativesdk recipe.
I really wasn't sure about the -cross recipe changes. The change to use
libtool.inc looked incorrect and the patch changes for the do_install
also worried me a little and at least need more explanation. Dropping
the PACKAGES line from the -cross recipe is also almost pretty certainly
incorrect.
Can you see if you're happy with the revised patch versions above and
also send out anything else you think is missing such as the suffix fix
above please.
Cheers,
Richard
next prev parent reply other threads:[~2011-01-19 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 4:19 [PATCH 0/9] libtool 2.4 sysroot support Scott Garman
2011-01-19 4:19 ` [PATCH 1/9] libtool: changes to enable " Scott Garman
2011-01-19 14:48 ` Richard Purdie
2011-01-19 16:05 ` Richard Purdie [this message]
2011-01-19 4:19 ` [PATCH 2/9] libtool: fix library RPATHs Scott Garman
2011-01-19 4:19 ` [PATCH 3/9] autotools.bbclass: libtool sysroot support changes Scott Garman
2011-01-19 4:19 ` [PATCH 4/9] staging.bbclass, utils.bbclass: remove la mangling code Scott Garman
2011-01-19 4:19 ` [PATCH 5/9] insane.bbclass: skip checks on .la installed status Scott Garman
2011-01-19 7:19 ` Koen Kooi
2011-01-19 18:27 ` Scott Garman
2011-01-19 19:17 ` Koen Kooi
2011-01-19 4:19 ` [PATCH 6/9] binutils: upgrade to 2.21 and add libtool sysroot support Scott Garman
2011-01-19 4:20 ` [PATCH 7/9] binutils: Fix QA staging errors for target binutils Scott Garman
2011-01-19 4:20 ` [PATCH 8/9] binutils: fix library RPATHs Scott Garman
2011-01-19 4:20 ` [PATCH 9/9] poky-default.inc: bump binutils preferred version to 2.21 Scott Garman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295453151.14388.22265.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=poky@yoctoproject.org \
--cc=scott.a.garman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.