From: Brian Gix <bgix@codeaurora.org>
To: linux-bluetooth@vger.kernel.org
Cc: vinicius.gomes@openbossa.org, claudio.takahasi@openbossa.org,
johan.hedberg@nokia.com, padovan@profusion.mobi,
rshaffer@codeaurora.org
Subject: Re: [PATCH 0/3] Add READ_BLOB support to attrib-server
Date: Wed, 19 Jan 2011 14:05:13 -0800 [thread overview]
Message-ID: <1295474713.1774.8.camel@ubuntuLab1> (raw)
In-Reply-To: <1295474453-8495-1-git-send-email-bgix@codeaurora.org>
Hi All -- Correction below.
On Wed, 2011-01-19 at 14:00 -0800, Brian Gix wrote:
> The following patches were cretated off of the working bluez tip at git.kernel.org as of:
>
> commit f0411254277e6c2273d32379e4a2d3742ee05e55
> Author: Johan Hedberg <johan.hedberg@nokia.com>
> Date: Wed Jan 19 22:20:41 2011 +0530
>
> Update NREC callback code to originally intended v2 state
>
>
> Patch 1 adds the default MTU for L2CAP based ATT connections (48) and
> modifies the usages for consistency. This is important when segmenting
> long attribute over multiple transactions, because remote clients will
> typically decide wether to issue subsequent READ_BLOB request based on wether
> the prior read filled the entire MTU. This explicitely does not address
> situations where a larger MTU than the defaults (23 and 48) are used, but
> in practice, there is no evidence that they exist at this time.
>
> Patch 2 is some maintanence to fix the attrib-server to correctly indicate
> the end of the service range, if a primary or secondary service contains
> nothing but the service declaration. This can be seen prior to this patch
> in attrib-server.c in the GATT_PRIM_SVC_UUID definition which sent a service
> range of 0x0010 - 0x0006 instead of 0x0010 - 0x0010.
What I meant was it is the GENERIC_ATTRIB_PROFILE_ID service which is
(prior to this patch) indicating an incorrect and invalid range.
> Patch 3 completes the implementation. It can be tested on the current example
> server by reading attribute 0x0214, which caontains a 25 octet string.
>
--
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
prev parent reply other threads:[~2011-01-19 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:00 [PATCH 0/3] Add READ_BLOB support to attrib-server Brian Gix
2011-01-19 22:00 ` [PATCH 1/3] Fix default GATT/ATT MTU sizes Brian Gix
2011-01-20 9:32 ` Johan Hedberg
2011-01-19 22:00 ` [PATCH 2/3] Fix Handle range if Pri/Sec Service is Empty Brian Gix
2011-01-20 9:33 ` Johan Hedberg
2011-01-19 22:00 ` [PATCH 3/3] Add READ_BLOB_REQUEST support to attribute server Brian Gix
2011-01-20 9:35 ` Johan Hedberg
2011-01-19 22:05 ` Brian Gix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295474713.1774.8.camel@ubuntuLab1 \
--to=bgix@codeaurora.org \
--cc=claudio.takahasi@openbossa.org \
--cc=johan.hedberg@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
--cc=rshaffer@codeaurora.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.