From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: of_flat_dt_match() helper build FAIL
Date: Fri, 21 Jan 2011 13:15:22 +1100 [thread overview]
Message-ID: <1295576122.2148.271.camel@pasglop> (raw)
a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:
/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{'
before 'const'
and more...
This hunk is obviously bogus:
+struct const char *board[] __initdata = {
+ "MPC8313ERDB",
+ "fsl,mpc8315erdb",
+ NULL
+}
+
You should at least compile test your changes :-(
Please send Linus a fix.
Cheers,
Ben.
next reply other threads:[~2011-01-21 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 2:15 Benjamin Herrenschmidt [this message]
2011-01-21 2:30 ` of_flat_dt_match() helper build FAIL Stephen Rothwell
2011-01-21 5:44 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295576122.2148.271.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.