From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@redhat.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: Fix some 6xx/7xxx CPU setup functions
Date: Fri, 21 Jan 2011 21:00:07 +1100 [thread overview]
Message-ID: <1295604007.2148.294.camel@pasglop> (raw)
In-Reply-To: <m31v4660zb.fsf@redhat.com>
On Fri, 2011-01-21 at 10:48 +0100, Andreas Schwab wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > In absence of good testing I would appreciate a close inspection of the patch
> > by different pairs of eyes :-)
>
> Looks good to me. That broke apparently in 400d221 ("ppc32: make
> cur_cpu_spec a single pointer instead of an array"), which changed the
> calling convention in call_setup_cpu.
Nice, >5 years ago and it's not even my fault :-) Thanks for the
review !
Cheers,
Ben.
next prev parent reply other threads:[~2011-01-21 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1295591723.2148.281.camel__36384.4125684865$1295591768$gmane$org@pasglop>
2011-01-21 9:48 ` [PATCH] powerpc: Fix some 6xx/7xxx CPU setup functions Andreas Schwab
2011-01-21 10:00 ` Benjamin Herrenschmidt [this message]
2011-01-21 6:35 Benjamin Herrenschmidt
2011-01-21 18:15 ` kevin diggs
2011-01-21 21:16 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295604007.2148.294.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=schwab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.