All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 6/8] qxl: locking fix
Date: Mon, 24 Jan 2011 17:20:47 +0100	[thread overview]
Message-ID: <1295886049-30548-7-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1295886049-30548-1-git-send-email-kraxel@redhat.com>

One spice worker call lacks the unlock/relock calls,
which may lead to deadlocks, add them.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/qxl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index dcea65d..fe4212b 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -866,7 +866,9 @@ static void qxl_destroy_primary(PCIQXLDevice *d)
     dprint(d, 1, "%s\n", __FUNCTION__);
 
     d->mode = QXL_MODE_UNDEFINED;
+    qemu_mutex_unlock_iothread();
     d->ssd.worker->destroy_primary_surface(d->ssd.worker, 0);
+    qemu_mutex_lock_iothread();
 }
 
 static void qxl_set_mode(PCIQXLDevice *d, int modenr, int loadvm)
-- 
1.7.1

  parent reply	other threads:[~2011-01-24 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 16:20 [Qemu-devel] [PULL 0/8] spice patch queue Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 1/8] add migration state change notifiers Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 2/8] spice/vnc: client migration Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 3/8] spice: MAINTAINERS update Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 4/8] vnc/spice: fix "never" and "now" expire_time Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 5/8] spice/qxl: zap spice 0.4 migration compatibility bits Gerd Hoffmann
2011-01-24 16:20 ` Gerd Hoffmann [this message]
2011-01-24 16:20 ` [Qemu-devel] [PATCH 7/8] configure: Fix spice probe Gerd Hoffmann
2011-01-28 13:37   ` [Qemu-devel] " Paolo Bonzini
2011-01-24 16:20 ` [Qemu-devel] [PATCH 8/8] spice: add chardev (v5) Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295886049-30548-7-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.