All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-mtd@lists.infradead.org,
	Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH v2 3/3] UBIFS: do not start the commit if there is nothing to commit
Date: Tue, 25 Jan 2011 10:20:34 +0200	[thread overview]
Message-ID: <1295943634.2227.1.camel@localhost> (raw)
In-Reply-To: <87d3nq338b.fsf@vostro.fn.ogness.net>

On Fri, 2011-01-21 at 12:28 +0100, John Ogness wrote:
> On 2011-01-21, Artem Bityutskiy wrote:
> > I need to look why there are still erases after mount.  Probably
> > this is actually part of mounting, not part of the first sync.  But
> > otherwise it sounds like you are satisfied, right?
> 
> Yes, it is definately a big improvement. Thanks!
> 
> > But I also have to do power cut tests emulation before really
> > pushing this forward.

The power cut simulation test is running.

> BTW: The return value description for the function nothing_to_commit()
> is backwards. It says that it returns 1 if there is something to
> commit, but actually it returns 1 if there is nothing to commit.

Amended, thanks. Also added:

Tested-by: John Ogness <john.ogness@linutronix.de>

Thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

      reply	other threads:[~2011-01-25  8:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 16:30 ubifs: sync() causes writes even if nothing is changed Hans J. Koch
2010-10-15  6:13 ` Artem Bityutskiy
2010-10-20 13:26 ` Artem Bityutskiy
2010-10-21  8:23   ` Sebastian Andrzej Siewior
2010-10-21  8:32     ` Artem Bityutskiy
2010-10-21 17:04       ` Matthieu CASTET
2010-10-21 18:43         ` Artem Bityutskiy
2011-01-16 17:48 ` Artem Bityutskiy
2011-01-17  8:19   ` Adrian Hunter
2011-01-17  9:04     ` Artem Bityutskiy
2011-01-17 21:52     ` Artem Bityutskiy
2011-01-17 21:53     ` [PATCH v2 1/3] UBIFS: re-arrange variables in ubifs_info Artem Bityutskiy
2011-01-17 21:54       ` [PATCH v2 2/3] UBIFS: introduce mounting flag Artem Bityutskiy
2011-01-18  7:30     ` [PATCH v2 3/3] UBIFS: do not start the commit if there is nothing to commit Artem Bityutskiy
2011-01-18  7:36       ` Artem Bityutskiy
2011-01-18 12:29         ` John Ogness
2011-01-21 11:13           ` Artem Bityutskiy
2011-01-21 11:28             ` John Ogness
2011-01-25  8:20               ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295943634.2227.1.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=adrian.hunter@nokia.com \
    --cc=bigeasy@linutronix.de \
    --cc=john.ogness@linutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.