All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org>
To: Thomas Chou <thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
Cc: Nios2 development list
	<nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: dts-binding doc for opencores
Date: Tue, 25 Jan 2011 10:33:30 +0100	[thread overview]
Message-ID: <1295948010.2178.32.camel@localhost> (raw)
In-Reply-To: <4D3E3764.1050603-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>

Hi Thomas,

> 
> As Grant suggested, we will need to document the dts property for 
> opencores drivers. Do you have any suggestion?
> 
> linux-2.6/Documentation/powerpc/dts-bindings/opencores.txt
> 
> project: tiny SPI controller
> core: tiny_spi
> driver: spi_oc_tiny
> compat: "opencores,tiny-spi-rtlsvn2"
> Optional properties:
>         - clock-frequency : input clock freq to the core
>         - baud-width: baud rate divider width of the core
> 

Is clock-frequency really optional?

Otherwise, I think this looks pretty good.  I'd add the following
though:

i) a description of the reg parameter, given that the address range of
the device is known:  0x10+ROUND_UP(BAUD_WIDTH/8) (right?)

reg: <BASE 0x10+ROUND_UP(BAUD_WIDTH/8)>

ii) add the 'interrupts' property to the list of optional properties

interrupts: <IRQ NUMBER>

Finally, the name 'baud-width' is a bit strange.  I know what you want
to say with it, but it doesn't feel very intuitive.  Perhaps
'clk-divider-bits'...???  or 'sclk-divider-bits'???

Otherwise, a better description of the baud-width parameter, perhaps:

baud-width:  width, in bits, of the programmable divider used to scale
the input clock to SCLK

Best regards,
Jonas

      parent reply	other threads:[~2011-01-25  9:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  2:37 dts-binding doc for opencores Thomas Chou
     [not found] ` <4D3E3764.1050603-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
2011-01-25  9:33   ` Jonas Bonn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295948010.2178.32.camel@localhost \
    --to=jonas-a9uvi2hlr7kop4wsbpiw7w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org \
    --cc=thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.