diff for duplicates of <1296001813.25686.27.camel@localhost> diff --git a/a/1.txt b/N1/1.txt index f336caa..dd225ee 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,10 @@ On Tue, 2011-01-25 at 18:05 -0500, Devin Heitmueller wrote: -> On Tue, Jan 25, 2011 at 5:54 PM, Peter Hüwe <PeterHuewe@gmx.de> wrote: +> On Tue, Jan 25, 2011 at 5:54 PM, Peter Hüwe <PeterHuewe@gmx.de> wrote: > > Hi Julia, > > > > thanks for your input. > > So do I understand you correctly if I say -> > if(!x) is better than if(x=NULL) in any case? +> > if(!x) is better than if(x==NULL) in any case? The machine code should be equivalent in size and speed. @@ -20,11 +20,11 @@ The machine code should be equivalent in size and speed. > > int result = 0; > > char *buffer = kmalloc(SIZE); > > -> > if (buffer = NULL) +> > if (buffer == NULL) > > return -ENOMEM; > > -> > --> So if (buffer = NULL) is in the official CodingStyle - maybe we should +> > --> So if (buffer == NULL) is in the official CodingStyle - maybe we should > > add a paragraph there as well ;) @@ -40,7 +40,7 @@ Correct, it does not. I just checked CodingStyle and checkpatch yesterday. -> Whether to do (!foo) or (foo = NULL) is one of those debates people +> Whether to do (!foo) or (foo == NULL) is one of those debates people > have similar to whether to use tabs as whitespace. People have > differing opinions and there is no clearly "right" answer. @@ -58,7 +58,7 @@ Ambiguity and implicit behaviors ultimately waste my time. > Personally -> I strongly prefer (foo = NULL) as it makes it blindingly obvious that +> I strongly prefer (foo == NULL) as it makes it blindingly obvious that > it's a pointer comparison, whereas (!foo) leaves you wondering whether > it's an integer or pointer comparison. @@ -78,8 +78,3 @@ the source code. I tend to give it less weight though. Regards, Andy - --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 7747ef3..6cd6f07 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,8 @@ "ref\0201101252354.31217.PeterHuewe@gmx.de\0" "ref\0AANLkTinap-4djdUORmOnnnVFtTm4wSxMqTNVxrfg2jYw@mail.gmail.com\0" "From\0Andy Walls <awalls@md.metrocast.net>\0" - "Subject\0Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer\0" - "Date\0Wed, 26 Jan 2011 00:30:13 +0000\0" + "Subject\0Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer as NULL pointer\0" + "Date\0Tue, 25 Jan 2011 19:30:13 -0500\0" "To\0Devin Heitmueller <dheitmueller@kernellabs.com>\0" "Cc\0Peter H\303\274we <PeterHuewe@gmx.de>" Julia Lawall <julia@diku.dk> @@ -18,12 +18,12 @@ "\00:1\0" "b\0" "On Tue, 2011-01-25 at 18:05 -0500, Devin Heitmueller wrote:\n" - "> On Tue, Jan 25, 2011 at 5:54 PM, Peter H\303\203\302\274we <PeterHuewe@gmx.de> wrote:\n" + "> On Tue, Jan 25, 2011 at 5:54 PM, Peter H\303\274we <PeterHuewe@gmx.de> wrote:\n" "> > Hi Julia,\n" "> >\n" "> > thanks for your input.\n" "> > So do I understand you correctly if I say\n" - "> > if(!x) is better than if(x=NULL) in any case?\n" + "> > if(!x) is better than if(x==NULL) in any case?\n" "\n" "The machine code should be equivalent in size and speed.\n" "\n" @@ -39,11 +39,11 @@ "> > int result = 0;\n" "> > char *buffer = kmalloc(SIZE);\n" "> >\n" - "> > if (buffer = NULL)\n" + "> > if (buffer == NULL)\n" "> > return -ENOMEM;\n" "\n" "> >\n" - "> > --> So if (buffer = NULL) is in the official CodingStyle - maybe we should\n" + "> > --> So if (buffer == NULL) is in the official CodingStyle - maybe we should\n" "> > add a paragraph there as well ;)\n" "\n" "\n" @@ -59,7 +59,7 @@ "yesterday.\n" "\n" "\n" - "> Whether to do (!foo) or (foo = NULL) is one of those debates people\n" + "> Whether to do (!foo) or (foo == NULL) is one of those debates people\n" "> have similar to whether to use tabs as whitespace. People have\n" "> differing opinions and there is no clearly \"right\" answer.\n" "\n" @@ -77,7 +77,7 @@ "\n" "\n" "> Personally\n" - "> I strongly prefer (foo = NULL) as it makes it blindingly obvious that\n" + "> I strongly prefer (foo == NULL) as it makes it blindingly obvious that\n" "> it's a pointer comparison, whereas (!foo) leaves you wondering whether\n" "> it's an integer or pointer comparison.\n" "\n" @@ -96,11 +96,6 @@ "\n" "\n" "Regards,\n" - "Andy\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Andy -c8fd81d957bd64bd4bd32618db4f9db43fbcc8da088d834a843731f10ed7da43 +0bc070db3234be1394c16b41c337a548a094b9c5165ad03470d32e5b96a556cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.