All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Kobylyanskiy <kentlinux@yandex.ru>
To: "Jan Engelhardt" <jengelh@medozas.de>
Cc: "Netfilter Developer Mailing List" <netfilter-devel@vger.kernel.org>
Subject: Re: TCP-packet with PUSH flag with wrong payload data in LOCAL_OUT
Date: Thu, 22 Jan 2009 19:54:05 +0300	[thread overview]
Message-ID: <12961232643245@webmail56.yandex.ru> (raw)
In-Reply-To: <alpine.LSU.2.00.0901221705140.30491@fbirervta.pbzchgretzou.qr>

22.01.09, 19:11, "Jan Engelhardt" <jengelh@medozas.de>:

> Very well. But there still is another case I can think of -
> non-linear skb.
> 	struct tcphdr tcpbuf;
> 	const struct tcphdr *th;
> 	
> 	th = skb_header_pointer(skb, ip_hdrlen(skb), sizeof(tcpbuf), &tcpbuf);
> 	if (th->psh && ntohs(tcp->dest) == 80) {
> 		char n[4];
> 		if (skb_copy_bits(skb, ip_hdrlen(skb) + 4*tcp->doff,
> 		    n, sizeof(n)) >= 0)
> 			printk("data: %02x %02x %02x %02x\n", n[0], n[1],
> 			       n[2], n[3]);
> 	}

Yes! It is non-linear skb! All works! THANK YOU VERY MUCH!
I try to fix this bug for about 2 weeks. And You fix it for 15 minutes!
Non of my books tell me about non-linear skb. Google was useless!
Man, You are the best! :)

I want to give You a little present - bottle of Russian vodka (old Russian tradition :) ). 
How can I pass it to You? Give me your address please!

  reply	other threads:[~2009-01-22 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 13:53 Re: TCP-packet with PUSH flag with wrong payload data in LOCAL_OUT Кобылянский Владимир
2009-01-22 14:27 ` Jan Engelhardt
2009-01-22 15:40   ` Vladimir Kobylyanskiy
2009-01-22 16:11     ` Jan Engelhardt
2009-01-22 16:54       ` Vladimir Kobylyanskiy [this message]
2009-01-22 17:22         ` Jan Engelhardt
2009-01-22 18:15       ` James King
2009-01-22 18:57         ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12961232643245@webmail56.yandex.ru \
    --to=kentlinux@yandex.ru \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.