Re: [PATCH 6/9] oFono smsagent enhancements to permit more flexible parameter set to be dispatched.

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Hi Oleg,

>  src/smsagent.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/src/smsagent.h b/src/smsagent.h
> index 39513d6..348d36d 100644
> --- a/src/smsagent.h
> +++ b/src/smsagent.h
> @@ -31,6 +31,8 @@ typedef void (*sms_agent_dispatch_cb)(struct sms_agent *agent,
>  					enum sms_agent_result result,
>  					void *data);
>  
> +typedef void (*sms_agent_dict_append_cb)(DBusMessageIter *dict, void *param);
> +
>  struct sms_agent *sms_agent_new(const char *interface,
>  					const char *service, const char *path);
>  
> @@ -49,4 +51,6 @@ int sms_agent_dispatch_datagram(struct sms_agent *agent, const char *method,
>  				const struct tm *local_sent_time,
>  				const unsigned char *content, unsigned int len,
>  				sms_agent_dispatch_cb cb, void *user_data,
> +				sms_agent_dict_append_cb dict_cb,
> +				void *dict_cb_data,
>  				ofono_destroy_func destroy);

I have a bunch of comments for the other patches, but what is this
about? I don't see any need to it.

Regards

Marcel