Re: [PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

Hi Gustavo,

> > >>   plugins/bluetooth.c |   14 +++++++++-----
> > >>   1 files changed, 9 insertions(+), 5 deletions(-)
> > >>
> > >> diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c
> > >> index 93dd7a1..e59bd31 100644
> > >> --- a/plugins/bluetooth.c
> > >> +++ b/plugins/bluetooth.c
> > >> @@ -505,7 +505,7 @@ static guint adapter_added_watch;
> > >>   static guint adapter_removed_watch;
> > >>   static guint property_watch;
> > >>
> > >> -static void bluetooth_ref(void)
> > >> +static int bluetooth_ref(void)
> > >>   {
> > >
> > > why are we now reverting something back that we already applied
> > > upstream. Something is wrong here.
> > 
> > I followed Padovan's comment on my first try for this patch :
> > "bluetooth_refcount can only be read/write by bluetooth_ref/unref"
> > which seems good to me
> 
> Yeah, but I'm now wondering why we merged a code access bluetooth_refcount
> directly.

that part is just fine. Don't worry about that.

Regards

Marcel