From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 0/6] libxl, xl: fix domain name uniqueness check
Date: Thu, 27 Jan 2011 17:40:58 +0000 [thread overview]
Message-ID: <1296150064-31991-1-git-send-email-ian.jackson@eu.citrix.com> (raw)
We knew that checking for the domain name uniqueness in
parse_config_data in xl was wrong. Sadly not only is it wrong, but it
doesn't work properly because it prevents the parsing of domain config
files in various other contextx.
Instead, in this series, we put this check in libxl_domain_rename,
which is the right place for it to be. This function is indeed called
during domain creation to set the domain's name at the start. As a
sop to those who think domain names are not important, we allow any
number of domains with the name "". This is not recommended.
However, after moving this check down into the bowels of libxl domain
creation, it became obvious during testing that the error paths with
are taken when the check fails didn't work properly and generated a
lot of noisy output.
So in this series:
patch 1: revert the original broken check
patches 2-5: error path fixes
patch 6: add the check to libxl_domain_rename
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
next reply other threads:[~2011-01-27 17:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 17:40 Ian Jackson [this message]
2011-01-27 17:40 ` [PATCH 1/6] xl: Revert "xl: avoid creating domains with duplicate names" Ian Jackson
2011-01-27 17:41 ` [PATCH 2/6] libxl: fix error handling (xenstore transaction leak) in libxl__domain_make Ian Jackson
2011-01-27 17:41 ` [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values) Ian Jackson
2011-01-27 17:41 ` [PATCH 4/6] libxl: internals: document the error behaviour of various libxl__xs_* functions Ian Jackson
2011-01-27 17:41 ` [PATCH 5/6] libxl: during domain destruction, do not complain if no devices dir to destroy Ian Jackson
2011-01-27 17:41 ` [PATCH 6/6] libxl: prevent creation of domains with duplicate names Ian Jackson
2011-01-27 18:33 ` [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values) Stefano Stabellini
2011-01-27 18:59 ` Ian Jackson
2011-01-27 20:01 ` Ian Jackson
2011-01-27 20:13 ` Gianni Tedesco
2011-01-28 12:22 ` Stefano Stabellini
2011-01-28 12:28 ` Ian Jackson
2011-01-28 13:27 ` Stefano Stabellini
2011-01-28 17:38 ` Ian Jackson
2011-01-28 17:52 ` Stefano Stabellini
2011-01-28 18:39 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296150064-31991-1-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.