From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 1/6] xl: Revert "xl: avoid creating domains with duplicate names" Date: Thu, 27 Jan 2011 17:40:59 +0000 Message-ID: <1296150064-31991-2-git-send-email-ian.jackson@eu.citrix.com> References: <1296150064-31991-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1296150064-31991-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org This reverts commit 22820:310cc33bfc81. This functionality should not be in the domain parsing logic. It needs to be in libxl_domain_make. Signed-off-by: Ian Jackson --- tools/libxl/xl_cmdimpl.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 76c6408..5826755 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -583,7 +583,6 @@ static void parse_config_data(const char *configfile_filename_report, XLU_ConfigList *vbds, *nics, *pcis, *cvfbs, *net2s, *cpuids; int pci_power_mgmt = 0; int pci_msitranslate = 1; - uint32_t domid_e; int e; libxl_domain_create_info *c_info = &d_config->c_info; @@ -613,15 +612,6 @@ static void parse_config_data(const char *configfile_filename_report, if (xlu_cfg_replace_string (config, "name", &c_info->name)) c_info->name = strdup("test"); - e = libxl_name_to_domid(&ctx, c_info->name, &domid_e); - if (!e) { - fprintf(stderr, "A domain with name \"%s\" already exists.\n", c_info->name); - exit(1); - } - if (e != ERROR_INVAL) { - fprintf(stderr, "Unexpected error checking for existing domain" - " (error=%d)", e); - } if (!xlu_cfg_get_string (config, "uuid", &buf) ) { if ( libxl_uuid_from_string(&c_info->uuid, buf) ) { -- 1.5.6.5