From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gianni Tedesco Subject: Re: [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values) Date: Thu, 27 Jan 2011 20:13:50 +0000 Message-ID: <1296159230.25215.47.camel@qabil.uk.xensource.com> References: <1296150064-31991-1-git-send-email-ian.jackson@eu.citrix.com> <1296150064-31991-2-git-send-email-ian.jackson@eu.citrix.com> <1296150064-31991-3-git-send-email-ian.jackson@eu.citrix.com> <1296150064-31991-4-git-send-email-ian.jackson@eu.citrix.com> <19777.49322.747849.408538@mariner.uk.xensource.com> <19777.53024.392960.80045@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19777.53024.392960.80045@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, 2011-01-27 at 20:01 +0000, Ian Jackson wrote: > > +static inline int libxl_domid_valid_guest(uint32_t domid) { > + /* returns 1 if the value _could_ be a valid guest domid, 0 otherwise > + * does not check whether the domain actually exists */ > + return domid > 0 && domid < DOMID_FIRST_RESERVED; > +} Looks good to me, apart from coding style (opening brace)... Gianni