From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lianhao Lu <lianhao.lu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/6] Added rpm support in meta-toolchain
Date: Thu, 27 Jan 2011 22:03:36 +0000 [thread overview]
Message-ID: <1296165816.27814.8796.camel@rex> (raw)
In-Reply-To: <cover.1296095614.git.lianhao.lu@intel.com>
Hi Lianhao,
On Thu, 2011-01-27 at 10:51 +0800, Lianhao Lu wrote:
> From: Lianhao Lu <lianhao.lu@intel.com>
>
> The purpose of this series of patches is to add rpm support in meta-toolchain creation,
> and also to fix bug #227.
>
> It makes the task populate_sdk in meta/recipes-core/meta/meta-toolchain.bb more generic
> to support installing packages from ipk, rpm, and deb files in creating meta-toolchain
> tarball, and move the populate_sdk task out of meta-toolchain.bb recipe into a bbclass.
>
> It added populate_sdk_xxx.bbclass for different package file format.
>
> The meta-toolchain installing process involes 2 set of packages, one is the host sdk
> set which contains packages of applications(e.g. cross-canadian compilers, qemu, etc.) and
> relevant run-time libraries, the other is the target sdk set which contains packages of target
> arch's libraries and header files to create a target rootfs for cross compiling purpose.So
> the patches also modifes and/or adds functions in package_deb.bbclass & package_rpm.bbclass
> to update the package index and to generate different installing configuration files for the
> tow different sets.
>
> It also fixed a bug in cross-canadian.bbclass to enable the package_deb.bbclass generate correct
> deb package files for cross-canadian recipies.
Its great to see this but I think we need to restructure the code a
little more aggressively and create some general functions to complete
this properly.
What I mean is that both rootfs_ipk and populate_sdk_ipk share code,
rootfs_deb and populate_sdk_deb share code and likewise for rpm.
What we need is a generic function where we specify where the target
directory is and a list of packages we want to install along with some
architecture information and it then goes and does it. Those functions
would like in package_xxx.bbclass. We should do similar things well in
one place rather than in two with slightly different implementations.
Do you agree?
Cheers,
Richard
next prev parent reply other threads:[~2011-01-27 22:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 2:51 [PATCH 0/6] Added rpm support in meta-toolchain Lianhao Lu
2011-01-27 2:51 ` [PATCH 1/6] cross-canadian/apt-native: support for debian package Lianhao Lu
2011-01-27 10:44 ` Joshua Lock
2011-01-27 2:51 ` [PATCH 6/6] meta_toolchain/populate_sdk: Made task populate_sdk more generic Lianhao Lu
2011-01-27 10:47 ` Joshua Lock
2011-01-27 2:51 ` [PATCH 3/6] populate_sdk_deb/package_deb: Added deb support for populate_sdk Lianhao Lu
2011-01-27 2:51 ` [PATCH 5/6] package_rpm/populate_sdk_rpm: Added rpm support for populate_sdk task Lianhao Lu
2011-01-27 10:46 ` Joshua Lock
2011-01-27 2:51 ` [PATCH 4/6] classes/populate_sdk_*: remove blanks Lianhao Lu
2011-01-27 10:46 ` Joshua Lock
2011-01-27 2:51 ` [PATCH 2/6] classes/populate_sdk_ipk.bbclass: newly created Lianhao Lu
2011-01-27 22:03 ` Richard Purdie [this message]
2011-01-28 4:13 ` [PATCH 0/6] Added rpm support in meta-toolchain Lu, Lianhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296165816.27814.8796.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=lianhao.lu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.