diff for duplicates of <1296224232-8115-2-git-send-email-julia@diku.dk> diff --git a/a/1.txt b/N1/1.txt index bddf92a..1a2f1ec 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,7 +13,7 @@ The semantic match that finds this problem is as follows: expression data; @@ -if (data = NULL) { ... +if (data == NULL) { ... * genlmsg_cancel(..., data); ... return ...; @@ -35,7 +35,7 @@ index 5f14c84..0a1f77b 100644 @@ -635,7 +635,7 @@ static int netlbl_cipsov4_listall_cb(struct cipso_v4_doi *doi_def, void *arg) cb_arg->seq, &netlbl_cipsov4_gnl_family, NLM_F_MULTI, NLBL_CIPSOV4_C_LISTALL); - if (data = NULL) + if (data == NULL) - goto listall_cb_failure; + return ret_val; @@ -48,7 +48,7 @@ index 998e85e..daaa01d 100644 @@ -452,7 +452,7 @@ static int netlbl_mgmt_listall_cb(struct netlbl_dom_map *entry, void *arg) cb_arg->seq, &netlbl_mgmt_gnl_family, NLM_F_MULTI, NLBL_MGMT_C_LISTALL); - if (data = NULL) + if (data == NULL) - goto listall_cb_failure; + return ret_val; @@ -57,7 +57,7 @@ index 998e85e..daaa01d 100644 @@ -617,7 +617,7 @@ static int netlbl_mgmt_protocols_cb(struct sk_buff *skb, &netlbl_mgmt_gnl_family, NLM_F_MULTI, NLBL_MGMT_C_PROTOCOLS); - if (data = NULL) + if (data == NULL) - goto protocols_cb_failure; + return ret_val; @@ -70,7 +70,7 @@ index e2b0a68..b5d3945 100644 @@ -1141,7 +1141,7 @@ static int netlbl_unlabel_staticlist_gen(u32 cmd, cb_arg->seq, &netlbl_unlabel_gnl_family, NLM_F_MULTI, cmd); - if (data = NULL) + if (data == NULL) - goto list_cb_failure; + return ret_val; diff --git a/a/content_digest b/N1/content_digest index bec5ea4..1c373a4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Julia Lawall <julia@diku.dk>\0" "Subject\0[PATCH 2/2] net/netlabel: Avoid call to genlmsg_cancel\0" - "Date\0Fri, 28 Jan 2011 13:58:20 +0000\0" + "Date\0Fri, 28 Jan 2011 15:17:12 +0100\0" "To\0Paul Moore <paul.moore@hp.com>\0" "Cc\0kernel-janitors@vger.kernel.org" David S. Miller <davem@davemloft.net> @@ -23,7 +23,7 @@ "expression data;\n" "@@\n" "\n" - "if (data = NULL) { ...\n" + "if (data == NULL) { ...\n" "* genlmsg_cancel(..., data);\n" " ...\n" " return ...;\n" @@ -45,7 +45,7 @@ "@@ -635,7 +635,7 @@ static int netlbl_cipsov4_listall_cb(struct cipso_v4_doi *doi_def, void *arg)\n" " \t\t\t cb_arg->seq, &netlbl_cipsov4_gnl_family,\n" " \t\t\t NLM_F_MULTI, NLBL_CIPSOV4_C_LISTALL);\n" - " \tif (data = NULL)\n" + " \tif (data == NULL)\n" "-\t\tgoto listall_cb_failure;\n" "+\t\treturn ret_val;\n" " \n" @@ -58,7 +58,7 @@ "@@ -452,7 +452,7 @@ static int netlbl_mgmt_listall_cb(struct netlbl_dom_map *entry, void *arg)\n" " \t\t\t cb_arg->seq, &netlbl_mgmt_gnl_family,\n" " \t\t\t NLM_F_MULTI, NLBL_MGMT_C_LISTALL);\n" - " \tif (data = NULL)\n" + " \tif (data == NULL)\n" "-\t\tgoto listall_cb_failure;\n" "+\t\treturn ret_val;\n" " \n" @@ -67,7 +67,7 @@ "@@ -617,7 +617,7 @@ static int netlbl_mgmt_protocols_cb(struct sk_buff *skb,\n" " \t\t\t &netlbl_mgmt_gnl_family, NLM_F_MULTI,\n" " \t\t\t NLBL_MGMT_C_PROTOCOLS);\n" - " \tif (data = NULL)\n" + " \tif (data == NULL)\n" "-\t\tgoto protocols_cb_failure;\n" "+\t\treturn ret_val;\n" " \n" @@ -80,11 +80,11 @@ "@@ -1141,7 +1141,7 @@ static int netlbl_unlabel_staticlist_gen(u32 cmd,\n" " \t\t\t cb_arg->seq, &netlbl_unlabel_gnl_family,\n" " \t\t\t NLM_F_MULTI, cmd);\n" - " \tif (data = NULL)\n" + " \tif (data == NULL)\n" "-\t\tgoto list_cb_failure;\n" "+\t\treturn ret_val;\n" " \n" " \tif (iface->ifindex > 0) {\n" " \t\tdev = dev_get_by_index(&init_net, iface->ifindex);" -89fe8c30fc622a5aa29b482dba271e7f87e0cbee1be6d7f562ed6529e28832ca +7785a21bf7f118a453f074d1be9b308cbb759883323cc13da7e9d9f38c743282
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.