diff for duplicates of <1296228218.5511.13.camel@sifl> diff --git a/a/1.txt b/N1/1.txt index 21b4fdf..d822d7f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,7 +17,7 @@ On Fri, 2011-01-28 at 15:58 +0100, Julia Lawall wrote: > > > expression data; > > > @@ > > > -> > > if (data = NULL) { ... +> > > if (data == NULL) { ... > > > * genlmsg_cancel(..., data); > > > ... > > > return ...; @@ -88,7 +88,7 @@ to the check nlmsg_trim(); that seems like a worthwhile addition. > > > @@ -635,7 +635,7 @@ static int netlbl_cipsov4_listall_cb(struct cipso_v4_doi *doi_def, void *arg) > > > cb_arg->seq, &netlbl_cipsov4_gnl_family, > > > NLM_F_MULTI, NLBL_CIPSOV4_C_LISTALL); -> > > if (data = NULL) +> > > if (data == NULL) > > > - goto listall_cb_failure; > > > + return ret_val; > > > @@ -101,7 +101,7 @@ to the check nlmsg_trim(); that seems like a worthwhile addition. > > > @@ -452,7 +452,7 @@ static int netlbl_mgmt_listall_cb(struct netlbl_dom_map *entry, void *arg) > > > cb_arg->seq, &netlbl_mgmt_gnl_family, > > > NLM_F_MULTI, NLBL_MGMT_C_LISTALL); -> > > if (data = NULL) +> > > if (data == NULL) > > > - goto listall_cb_failure; > > > + return ret_val; > > > @@ -110,7 +110,7 @@ to the check nlmsg_trim(); that seems like a worthwhile addition. > > > @@ -617,7 +617,7 @@ static int netlbl_mgmt_protocols_cb(struct sk_buff *skb, > > > &netlbl_mgmt_gnl_family, NLM_F_MULTI, > > > NLBL_MGMT_C_PROTOCOLS); -> > > if (data = NULL) +> > > if (data == NULL) > > > - goto protocols_cb_failure; > > > + return ret_val; > > > @@ -123,7 +123,7 @@ to the check nlmsg_trim(); that seems like a worthwhile addition. > > > @@ -1141,7 +1141,7 @@ static int netlbl_unlabel_staticlist_gen(u32 cmd, > > > cb_arg->seq, &netlbl_unlabel_gnl_family, > > > NLM_F_MULTI, cmd); -> > > if (data = NULL) +> > > if (data == NULL) > > > - goto list_cb_failure; > > > + return ret_val; > > > diff --git a/a/content_digest b/N1/content_digest index db12b45..c8632b8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0Pine.LNX.4.64.1101281541030.8546@pc-004.diku.dk\0" "From\0Paul Moore <paul.moore@hp.com>\0" "Subject\0Re: [PATCH 2/2] net/netlabel: Avoid call to genlmsg_cancel\0" - "Date\0Fri, 28 Jan 2011 15:23:38 +0000\0" + "Date\0Fri, 28 Jan 2011 10:23:38 -0500\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0kernel-janitors@vger.kernel.org" David S. Miller <davem@davemloft.net> @@ -30,7 +30,7 @@ "> > > expression data;\n" "> > > @@\n" "> > > \n" - "> > > if (data = NULL) { ...\n" + "> > > if (data == NULL) { ...\n" "> > > * genlmsg_cancel(..., data);\n" "> > > ...\n" "> > > return ...;\n" @@ -101,7 +101,7 @@ "> > > @@ -635,7 +635,7 @@ static int netlbl_cipsov4_listall_cb(struct cipso_v4_doi *doi_def, void *arg)\n" "> > > \t\t\t cb_arg->seq, &netlbl_cipsov4_gnl_family,\n" "> > > \t\t\t NLM_F_MULTI, NLBL_CIPSOV4_C_LISTALL);\n" - "> > > \tif (data = NULL)\n" + "> > > \tif (data == NULL)\n" "> > > -\t\tgoto listall_cb_failure;\n" "> > > +\t\treturn ret_val;\n" "> > > \n" @@ -114,7 +114,7 @@ "> > > @@ -452,7 +452,7 @@ static int netlbl_mgmt_listall_cb(struct netlbl_dom_map *entry, void *arg)\n" "> > > \t\t\t cb_arg->seq, &netlbl_mgmt_gnl_family,\n" "> > > \t\t\t NLM_F_MULTI, NLBL_MGMT_C_LISTALL);\n" - "> > > \tif (data = NULL)\n" + "> > > \tif (data == NULL)\n" "> > > -\t\tgoto listall_cb_failure;\n" "> > > +\t\treturn ret_val;\n" "> > > \n" @@ -123,7 +123,7 @@ "> > > @@ -617,7 +617,7 @@ static int netlbl_mgmt_protocols_cb(struct sk_buff *skb,\n" "> > > \t\t\t &netlbl_mgmt_gnl_family, NLM_F_MULTI,\n" "> > > \t\t\t NLBL_MGMT_C_PROTOCOLS);\n" - "> > > \tif (data = NULL)\n" + "> > > \tif (data == NULL)\n" "> > > -\t\tgoto protocols_cb_failure;\n" "> > > +\t\treturn ret_val;\n" "> > > \n" @@ -136,7 +136,7 @@ "> > > @@ -1141,7 +1141,7 @@ static int netlbl_unlabel_staticlist_gen(u32 cmd,\n" "> > > \t\t\t cb_arg->seq, &netlbl_unlabel_gnl_family,\n" "> > > \t\t\t NLM_F_MULTI, cmd);\n" - "> > > \tif (data = NULL)\n" + "> > > \tif (data == NULL)\n" "> > > -\t\tgoto list_cb_failure;\n" "> > > +\t\treturn ret_val;\n" "> > > \n" @@ -159,4 +159,4 @@ "paul moore\n" linux @ hp -737f8967360db55fd1ddb9faa2479b46a4946650e01e5ea446b523da3369c6b4 +7dd442b5bd701dfa3c5ff7760b8e475747fa7355ddc0752ed6aea9a6a9e2faa9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.