From: Miia Leinonen <miia.leinonen@tieto.com>
To: ofono@ofono.org
Subject: Re: [PATCH] TODO: SMS Validity Period
Date: Mon, 31 Jan 2011 12:06:45 +0200 [thread overview]
Message-ID: <1296468405.1662.67.camel@miia-desktop> (raw)
In-Reply-To: <1296467266.1520.189.camel@aeonflux>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
Hi Marcel,
> > +- Add support for setting the SMS Validity Period (3GPP 23.040). Currently the
> > + value is hard coded as 24 hours.
>
> didn't we actually change this to be the maximum value?
Only place I could find this to be edited was following line in
smsutil.c (3421)
template.submit.vp.relative = 0xA7; /* 24 Hours */
Have I missed something then?
In any case, I'd rather see the value something that API allows to set
instead of hard coded value, as user can have different needs for the
SMS validity period and sometimes it is not the best thing either that
period is set to maximum.
BR,
Miia
_______________________________________________
ofono mailing list
ofono(a)ofono.org
http://lists.ofono.org/listinfo/ofono
next prev parent reply other threads:[~2011-01-31 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 9:01 [PATCH] TODO: SMS Validity Period Miia Leinonen
2011-01-31 9:47 ` Marcel Holtmann
2011-01-31 10:06 ` Miia Leinonen [this message]
2011-01-31 10:31 ` Marcel Holtmann
2011-01-31 11:23 ` Aki Niemi
2011-01-31 12:42 ` Marcel Holtmann
2011-02-01 20:19 ` Aki Niemi
2011-02-02 6:52 ` Marcel Holtmann
2011-01-31 12:27 ` Miia.Leinonen
2011-01-31 12:52 ` Marcel Holtmann
2011-01-31 14:54 ` Miia Leinonen
2011-01-31 15:44 ` Marcel Holtmann
2011-02-01 13:01 ` Miia Leinonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296468405.1662.67.camel@miia-desktop \
--to=miia.leinonen@tieto.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.