From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org, bruno randolf <br1@einfach.org>
Subject: Re: [BUG] iwlwifi need to correct channels info
Date: Mon, 31 Jan 2011 11:53:08 +0100 [thread overview]
Message-ID: <1296471188.3812.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110131093840.GA20613@redhat.com>
On Mon, 2011-01-31 at 10:38 +0100, Stanislaw Gruszka wrote:
> > No, the above commit is buggy -- it assumes sband->band is set when it
> > isn't.
> But it should be, no? It seems we initialize it nowhere, but it's
> used in iwl-*-rs.c
Yes, but it'll be set by cfg80211 when you register the wiphy as well.
This code is just special because it's before registration.
> BTW:
> Is iwl_eeprom_band_2[] array correct? It have 7, 8, 11, 12 channels entries
> on 5GHz.
Huh, not sure.
> Can we get rid of /* FIXME: might be removed if scan is OK */ ?
Not sure either.
> > Does this fix it?
>
> I tested on 3945, it fix freq=0 on messages. But what about something
> slightly different? Use ch->band already set in iwl_init_channel_map()
> and initialize sband->band.
Sure, looks fine too.
johannes
next prev parent reply other threads:[~2011-01-31 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 15:41 [BUG] iwlwifi need to correct channels info Stanislaw Gruszka
2011-01-28 18:06 ` Johannes Berg
2011-01-31 9:38 ` Stanislaw Gruszka
2011-01-31 10:53 ` Johannes Berg [this message]
2011-01-31 11:33 ` Stanislaw Gruszka
2011-01-31 10:44 ` Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296471188.3812.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=br1@einfach.org \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.