All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: Rajkumar Manoharan <rmanoharan@atheros.com>,
	Rajkumar Manoharan <Rajkumar.Manoharan@atheros.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: deauthenticate STAs before suspend
Date: Mon, 31 Jan 2011 13:09:08 +0100	[thread overview]
Message-ID: <1296475748.3812.22.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110131114717.GA2919@jm.kir.nu>

On Mon, 2011-01-31 at 13:47 +0200, Jouni Malinen wrote:
> On Mon, Jan 31, 2011 at 05:08:35PM +0530, Rajkumar Manoharan wrote:
> > On Mon, Jan 31, 2011 at 04:57:41PM +0530, Johannes Berg wrote:
> > > Is that a big problem? We actually had this intentionally, and we go to
> > > PS before going to sleep, so if the sleep is very short then we will not
> > > be disconnected. Also, it's much easier this way to implement WoWLAN.
> > I looked it as a problem ;) And if we use NM/supplicant, obviously the STA
> > got disconnected. So just to align with that I sent the RFC.
> 
> While this may behave differently if NM is running (wpa_supplicant
> should not be being the disconnection on suspend), the comment about
> Wake-on-WLAN is something that should be considered here. I would expect
> there to be some interest in being able to support it and forcing a
> disconnection on suspend would make that impossible. In addition,
> extended PS mode from 802.11v will make it even more desirable to be
> able to sleep for extended periods of time without dropping the
> association for some use cases. If we force a disconnection here, we
> would need to have a flag for disabling that if there is any chance of
> the association being of use for something else after the resume or if
> Wake-on-WLAN is enabled.

I just don't see why we need the additional complexity of disabling it
and then re-enabling it conditionally when we want WoWL or 11v extended
PS?

IOW, I'd rather leave it as is. It seems there isn't really a problem,
but rather a perceived inconsistency that is being "fixed"?

johannes


  reply	other threads:[~2011-01-31 12:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 10:06 [RFC] mac80211: deauthenticate STAs before suspend Rajkumar Manoharan
2011-01-31 11:27 ` Johannes Berg
2011-01-31 11:38   ` Rajkumar Manoharan
2011-01-31 11:47     ` Jouni Malinen
2011-01-31 12:09       ` Johannes Berg [this message]
2011-01-31 12:00 ` Sujith
     [not found] <ce260d15f83b54d9a328a2d636cf9a4e@rss.opera.com>
2011-02-01 10:02 ` Arend van Spriel
2011-02-01 14:37   ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296475748.3812.22.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Rajkumar.Manoharan@atheros.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmanoharan@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.