From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Subject: Re: [PATCH v2 06/10] mac80211: add HW flag for disabling auto link-PS in AP mode
Date: Mon, 31 Jan 2011 13:11:50 +0100 [thread overview]
Message-ID: <1296475910.3812.27.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTin9vOQJqDJezzBMjjRyGNDYGEwOwgT_aFk2NBYD@mail.gmail.com>
On Mon, 2011-01-31 at 13:49 +0200, Arik Nemtsov wrote:
> On Mon, Jan 31, 2011 at 13:24, Johannes Berg <johannes@sipsolutions.net> wrote:
> > It'd be nicer if you could separate out mac80211 patches, but then Luca
> > needs to hold off merging until John picked up the mac80211 patch.
>
> Yea that would complicate matters a bit. Does the ordering of the
> patches bother you?
It just makes it more complicated for me to pick out the right thing --
I almost missed that there was a mac80211 patch in this huge series.
> > Also, come to think of it, the ieee80211_sta_block_awake will not be
> > effective I think? Or will it?
>
> Haven't noticed any adverse effects. ap_sta_ps_end() still checks if
> the station is blocked before delivering queued packets.
>
> Also is should be pretty hard to find a driver that uses both mechanisms.
> If it wants to block a station from waking up, it can simply not call
> ieee80211_sta_ps_transition().
>
> Should work though.
Good point, thanks for looking.
johannes
next prev parent reply other threads:[~2011-01-31 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 11:16 [PATCH v2 00/10] wl12xx: AP-mode per link PSM Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 01/10] wl12xx: fix potential race condition with TX queue watermark Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 02/10] wl12xx: AP-mode - fix race condition on sta connection Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 03/10] wl12xx: AP-mode - TX queue per link in AC Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 04/10] mac80211: do not calc frame duration when using HW rate-control Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 05/10] wl12xx: report invalid TX rate when returning non-TX-ed skbs Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 06/10] mac80211: add HW flag for disabling auto link-PS in AP mode Arik Nemtsov
2011-01-31 11:24 ` Johannes Berg
2011-01-31 11:49 ` Arik Nemtsov
2011-01-31 12:11 ` Johannes Berg [this message]
2011-01-31 20:06 ` Luciano Coelho
2011-01-31 20:16 ` Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 07/10] wl12xx: AP-mode - support HW based link PS monitoring Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 08/10] wl12xx: AP mode - fix bug in cleanup of wl1271_op_sta_add() Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 09/10] wl12xx: AP-mode - count free FW TX blocks per link Arik Nemtsov
2011-01-31 11:16 ` [PATCH v2 10/10] wl12xx: AP-mode - management of links in PS-mode Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296475910.3812.27.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.