From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: Accept any logical value WM8903 GPIO set() Date: Mon, 31 Jan 2011 13:54:51 +0000 Message-ID: <1296482091.3316.161.camel@odin> References: <1296481345-20173-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) by alsa0.perex.cz (Postfix) with ESMTP id C3867103899 for ; Mon, 31 Jan 2011 14:54:55 +0100 (CET) Received: by wyi11 with SMTP id 11so5468522wyi.38 for ; Mon, 31 Jan 2011 05:54:55 -0800 (PST) In-Reply-To: <1296481345-20173-1-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, swarren@nvidia.com List-Id: alsa-devel@alsa-project.org On Mon, 2011-01-31 at 13:42 +0000, Mark Brown wrote: > Signed-off-by: Mark Brown > --- > sound/soc/codecs/wm8903.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c > index 54383c3..27cd8f5 100644 > --- a/sound/soc/codecs/wm8903.c > +++ b/sound/soc/codecs/wm8903.c > @@ -1904,7 +1904,8 @@ static void wm8903_gpio_set(struct gpio_chip *chip, unsigned offset, int value) > struct snd_soc_codec *codec = wm8903->codec; > > snd_soc_update_bits(codec, WM8903_GPIO_CONTROL_1 + offset, > - WM8903_GP1_LVL_MASK, value << WM8903_GP1_LVL_SHIFT); > + WM8903_GP1_LVL_MASK, > + !!value << WM8903_GP1_LVL_SHIFT); > } > > static struct gpio_chip wm8903_template_chip = { Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk