From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: Accept any logical value for WM8962 GPIO set() Date: Mon, 31 Jan 2011 17:02:06 +0000 Message-ID: <1296493326.3316.208.camel@odin> References: <1296482111-3022-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) by alsa0.perex.cz (Postfix) with ESMTP id 28B981037E3 for ; Mon, 31 Jan 2011 18:02:10 +0100 (CET) Received: by wyi11 with SMTP id 11so5657967wyi.38 for ; Mon, 31 Jan 2011 09:02:09 -0800 (PST) In-Reply-To: <1296482111-3022-1-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com List-Id: alsa-devel@alsa-project.org On Mon, 2011-01-31 at 13:55 +0000, Mark Brown wrote: > Signed-off-by: Mark Brown > --- > sound/soc/codecs/wm8962.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c > index 5c7b730..3b71dd6 100644 > --- a/sound/soc/codecs/wm8962.c > +++ b/sound/soc/codecs/wm8962.c > @@ -3635,7 +3635,7 @@ static void wm8962_gpio_set(struct gpio_chip *chip, unsigned offset, int value) > struct snd_soc_codec *codec = wm8962->codec; > > snd_soc_update_bits(codec, WM8962_GPIO_BASE + offset, > - WM8962_GP2_LVL, value << WM8962_GP2_LVL_SHIFT); > + WM8962_GP2_LVL, !!value << WM8962_GP2_LVL_SHIFT); > } > > static int wm8962_gpio_direction_out(struct gpio_chip *chip, Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk