From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lianhao Lu <lianhao.lu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/8] image/package_xx/rootfs_xx.bbclass: move rootfs_xx_log_check().
Date: Mon, 31 Jan 2011 21:37:28 +0000 [thread overview]
Message-ID: <1296509848.13501.15224.camel@rex> (raw)
In-Reply-To: <c00770ba3d5adbda2e1164735e3bde13b4b15362.1296375580.git.lianhao.lu@intel.com>
On Sun, 2011-01-30 at 16:22 +0800, Lianhao Lu wrote:
> From: Lianhao Lu <lianhao.lu@intel.com>
>
> Move function rootfs_xx_log_check() from rootfs_xx.bbclass to relevant
> package_xx.bbclass. (Where xx is rpm/ipk/deb).
>
> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
> ---
> meta/classes/image.bbclass | 5 +----
> meta/classes/package_deb.bbclass | 20 ++++++++++++++++++++
> meta/classes/package_ipk.bbclass | 20 ++++++++++++++++++++
> meta/classes/package_rpm.bbclass | 20 ++++++++++++++++++++
> meta/classes/rootfs_deb.bbclass | 20 --------------------
> meta/classes/rootfs_ipk.bbclass | 20 --------------------
> meta/classes/rootfs_rpm.bbclass | 20 --------------------
> 7 files changed, 61 insertions(+), 64 deletions(-)
I've merged this to master since it is an improvement, thanks. Given the
similarity between the functions it would be nice to perhaps just define
a list of error strings in the package_xxx.bbclass and then have the
code to search for those strings in a shared core function?
Cheers,
Richard
next prev parent reply other threads:[~2011-01-31 21:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 8:22 [PATCH 0/8] [BUG# 227] Added generic populate_sdk task Lianhao Lu
2011-01-30 8:22 ` [PATCH 5/8] populate_sdk_rpm.bbclass: Added rpm support for " Lianhao Lu
2011-01-30 8:22 ` [PATCH 6/8] populate_sdk_deb.bbclass: Added deb " Lianhao Lu
2011-01-30 8:22 ` [PATCH 1/8] image/package_xx/rootfs_xx.bbclass: move rootfs_xx_log_check() Lianhao Lu
2011-01-31 21:37 ` Richard Purdie [this message]
2011-01-30 8:22 ` [PATCH 2/8] rootfs_deb/package_deb.bbclass: move func from rootfs_deb to package_deb Lianhao Lu
2011-01-30 8:22 ` [PATCH 8/8] populate_sdk.bbclass/meta-toolchain: Made populate_sdk task more generic Lianhao Lu
2011-01-30 8:22 ` [PATCH 4/8] rootfs_rpm/package_rpm.bbclass: Move func from rootfs_rpm to package_rpm Lianhao Lu
2011-01-30 8:22 ` [PATCH 7/8] populate_sdk_ipk.bbclass: Added ipk support in populate_sdk task Lianhao Lu
2011-01-30 8:22 ` [PATCH 3/8] rootfs_ipk/package_ipk.bbclass: Move func from rootfs_ipk to package_ipk Lianhao Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296509848.13501.15224.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=lianhao.lu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.