From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [Resend] [PATCH] ASoC: Amstrad Delta: fix const related build error
Date: Tue, 01 Feb 2011 14:02:24 +0000 [thread overview]
Message-ID: <1296568944.3327.15.camel@odin> (raw)
In-Reply-To: <201102011111.56190.jkrzyszt@tis.icnet.pl>
On Tue, 2011-02-01 at 11:11 +0100, Janusz Krzysztofik wrote:
> The Amstrad Delta ASoC driver used to override the digital_mute()
> callback, expected to be not provided by the on-board CX20442 CODEC
> driver, with its own implementation. While this is still posssible when
> substituting the whole empty snd_soc_dai_driver.ops member (the CX20442
> case), replacing snd_soc_dai_ops.digital_mute only is no longer correct
> after the snd_soc_dai_driver.ops member has been constified, and results
> in build error.
>
> Drop this actually not used code path in hope the CX20442 driver never
> provides its own snd_soc_dai_ops structure.
>
> Created and tested against linux-2.6.38-rc2
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> ---
> Resending because of line wrap, sorry.
> Please consider queuing this patch for the current rc cycle.
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-02-01 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 9:38 [PATCH] ASoC: Amstrad Delta: fix const related build error Janusz Krzysztofik
2011-02-01 10:11 ` [Resend] " Janusz Krzysztofik
2011-02-01 14:02 ` Liam Girdwood [this message]
2011-02-01 14:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296568944.3327.15.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkrzyszt@tis.icnet.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.