From mboxrd@z Thu Jan  1 00:00:00 1970
From: Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: CX20442: fix NULL pointer dereference
Date: Tue, 01 Feb 2011 14:30:24 +0000
Message-ID: <1296570624.3327.39.camel@odin>
References: <201102011301.17699.jkrzyszt@tis.icnet.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51])
	by alsa0.perex.cz (Postfix) with ESMTP id 1E059103998
	for <alsa-devel@alsa-project.org>; Tue,  1 Feb 2011 15:30:46 +0100 (CET)
Received: by wwe15 with SMTP id 15so6823142wwe.20
	for <alsa-devel@alsa-project.org>; Tue, 01 Feb 2011 06:30:45 -0800 (PST)
In-Reply-To: <201102011301.17699.jkrzyszt@tis.icnet.pl>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@opensource.wolfsonmicro.com>
List-Id: alsa-devel@alsa-project.org

On Tue, 2011-02-01 at 13:01 +0100, Janusz Krzysztofik wrote:
> The CX20442 codec driver never provided the snd_soc_codec_driver's 
> .reg_cache_default member. With the latest ASoC framework changes, it 
> seems to be referred unconditionally, resulting in a NULL pointer 
> dereference if missing. Provide it.
> 
> Created and tested on Amstrad Delta against linux-2.6.38-rc2
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> ---
> NOTE:
> I'm not sure if the value choosen is Amstrad Delta specific or not.
> 
>  sound/soc/codecs/cx20442.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- git/sound/soc/codecs/cx20442.c.orig	2011-01-31 20:09:18.000000000 +0100
> +++ git/sound/soc/codecs/cx20442.c	2011-01-31 20:16:20.000000000 +0100
> @@ -367,9 +367,12 @@ static int cx20442_codec_remove(struct s
>  	return 0;
>  }
>  
> +static const u8 cx20442_reg = CX20442_TELOUT | CX20442_MIC;
> +
>  static struct snd_soc_codec_driver cx20442_codec_dev = {
>  	.probe = 	cx20442_codec_probe,
>  	.remove = 	cx20442_codec_remove,
> +	.reg_cache_default = &cx20442_reg,
>  	.reg_cache_size = 1,
>  	.reg_word_size = sizeof(u8),
>  	.read = cx20442_read_reg_cache,
> _______________________________________________

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk