From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled
Date: Wed, 02 Feb 2011 18:11:30 -0500 [thread overview]
Message-ID: <1296688290.26428.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1296687674-23121-1-git-send-email-rohara@redhat.com>
On Wed, 2011-02-02 at 17:01 -0600, Ryan O'Hara wrote:
> This patch checks that dbus signals are not disabled before sending a
> dbus signal.
>
> Signed-off-by: Ryan O'Hara <rohara@redhat.com>
> ---
> fence/fenced/recover.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
> index 5d7680d..6fdd116 100644
> --- a/fence/fenced/recover.c
> +++ b/fence/fenced/recover.c
> @@ -384,7 +384,9 @@ void fence_victims(struct fd *fd)
> log_error("fence %s %s", node->name,
> error ? "failed" : "success");
>
> - dbus_send(node->name, node->nodeid, error);
> + if (!optd_disable_dbus) {
> + dbus_send(node->name, node->nodeid, error);
> + }
Indentation style doesn't match Dave's here or in dbus.c
I approve, but Dave really needs to sign off too.
-- Lon
next prev parent reply other threads:[~2011-02-02 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 23:01 [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled Ryan O'Hara
2011-02-02 23:11 ` Lon Hohberger [this message]
2011-02-02 23:34 ` Ryan O'Hara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296688290.26428.0.camel@localhost.localdomain \
--to=lhh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.