From: arve@android.com (Arve Hjønnevåg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: etm: Don't trigger another overflow when trying to clear the RAM-full status
Date: Wed, 2 Feb 2011 18:54:21 -0800 [thread overview]
Message-ID: <1296701663-12168-3-git-send-email-arve@android.com> (raw)
In-Reply-To: <1296701663-12168-1-git-send-email-arve@android.com>
If the write address was at the end of the buffer, toggling the trace
capture bit would set the RAM-full status instead of clearing it.
Signed-off-by: Arve Hj?nnev?g <arve@android.com>
---
arch/arm/kernel/etm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/kernel/etm.c b/arch/arm/kernel/etm.c
index 2ea0b7c..7652e9f 100644
--- a/arch/arm/kernel/etm.c
+++ b/arch/arm/kernel/etm.c
@@ -235,6 +235,7 @@ static void etm_dump(void)
printk(KERN_INFO "\n--- ETB buffer end ---\n");
/* deassert the overflow bit */
+ etb_writel(t, 0, ETBR_WRITEADDR);
etb_writel(t, 1, ETBR_CTRL);
etb_writel(t, 0, ETBR_CTRL);
@@ -300,6 +301,7 @@ static ssize_t etb_read(struct file *file, char __user *data,
buf[i] = etb_readl(t, ETBR_READMEM);
/* the only way to deassert overflow bit in ETB status is this */
+ etb_writel(t, 0, ETBR_WRITEADDR);
etb_writel(t, 1, ETBR_CTRL);
etb_writel(t, 0, ETBR_CTRL);
--
1.7.3.1
WARNING: multiple messages have this Message-ID (diff)
From: "Arve Hjønnevåg" <arve@android.com>
To: linux-arm-kernel@lists.infradead.org
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Alexander Shishkin" <virtuoso@slind.org>,
"Jason Wessel" <jason.wessel@windriver.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] ARM: etm: Don't trigger another overflow when trying to clear the RAM-full status
Date: Wed, 2 Feb 2011 18:54:21 -0800 [thread overview]
Message-ID: <1296701663-12168-3-git-send-email-arve@android.com> (raw)
In-Reply-To: <1296701663-12168-1-git-send-email-arve@android.com>
If the write address was at the end of the buffer, toggling the trace
capture bit would set the RAM-full status instead of clearing it.
Signed-off-by: Arve Hjønnevåg <arve@android.com>
---
arch/arm/kernel/etm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/kernel/etm.c b/arch/arm/kernel/etm.c
index 2ea0b7c..7652e9f 100644
--- a/arch/arm/kernel/etm.c
+++ b/arch/arm/kernel/etm.c
@@ -235,6 +235,7 @@ static void etm_dump(void)
printk(KERN_INFO "\n--- ETB buffer end ---\n");
/* deassert the overflow bit */
+ etb_writel(t, 0, ETBR_WRITEADDR);
etb_writel(t, 1, ETBR_CTRL);
etb_writel(t, 0, ETBR_CTRL);
@@ -300,6 +301,7 @@ static ssize_t etb_read(struct file *file, char __user *data,
buf[i] = etb_readl(t, ETBR_READMEM);
/* the only way to deassert overflow bit in ETB status is this */
+ etb_writel(t, 0, ETBR_WRITEADDR);
etb_writel(t, 1, ETBR_CTRL);
etb_writel(t, 0, ETBR_CTRL);
--
1.7.3.1
next prev parent reply other threads:[~2011-02-03 2:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 2:54 [PATCH 1/5] ARM: etm: Don't require clock control Arve Hjønnevåg
2011-02-03 2:54 ` Arve Hjønnevåg
2011-02-03 2:54 ` [PATCH 2/5] ARM: etm: Don't limit tracing to only non-secure code Arve Hjønnevåg
2011-02-03 2:54 ` Arve Hjønnevåg
2011-02-03 2:54 ` Arve Hjønnevåg [this message]
2011-02-03 2:54 ` [PATCH 3/5] ARM: etm: Don't trigger another overflow when trying to clear the RAM-full status Arve Hjønnevåg
2011-02-03 2:54 ` [PATCH 4/5] ARM: etm: Allow range selection Arve Hjønnevåg
2011-02-03 2:54 ` Arve Hjønnevåg
2011-02-03 2:54 ` [PATCH 5/5] ARM: etm: Configure data tracing Arve Hjønnevåg
2011-02-03 2:54 ` Arve Hjønnevåg
2011-02-03 12:45 ` [PATCH 1/5] ARM: etm: Don't require clock control Mark Brown
2011-02-03 12:45 ` Mark Brown
2011-02-04 0:30 ` Arve Hjønnevåg
2011-02-04 0:30 ` Arve Hjønnevåg
2011-02-04 14:31 ` Mark Brown
2011-02-04 14:31 ` Mark Brown
2011-02-15 6:11 ` [PATCH 1/8] " Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 2/8] ARM: etm: Don't limit tracing to only non-secure code Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 3/8] ARM: etm: Don't try to clear the buffer full status after reading the buffer Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 4/8] ARM: etm: Allow range selection Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 13:50 ` Alexander Shishkin
2011-02-15 13:50 ` Alexander Shishkin
2011-02-15 13:50 ` Alexander Shishkin
2011-02-15 23:04 ` Arve Hjønnevåg
2011-02-15 23:04 ` Arve Hjønnevåg
2011-02-15 23:04 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 5/8] ARM: etm: Configure data tracing Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 6/8] ARM: etm: Add some missing locks and error checks Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 7/8] ARM: etm: Return the entire trace buffer if it is empty after reset Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-15 6:11 ` [PATCH 8/8] ARM: etm: Support multiple ETMs/PTMs Arve Hjønnevåg
2011-02-15 6:11 ` Arve Hjønnevåg
2011-02-24 1:36 ` [PATCH 9/9 (originally 8)] ARM: etm: Power down etm(s) when tracing is not enabled Arve Hjønnevåg
2011-02-24 1:36 ` Arve Hjønnevåg
2011-02-24 1:36 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296701663-12168-3-git-send-email-arve@android.com \
--to=arve@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.