From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kees Cook <kees.cook@canonical.com>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>, Tejun Heo <tj@kernel.org>,
Marcus Meissner <meissner@suse.de>,
Jason Wessel <jason.wessel@windriver.com>,
Eugene Teo <eugeneteo@kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Len Brown <len.brown@intel.com>, Changli Gao <xiaosuo@gmail.com>,
Dan Rosenberg <drosenberg@vsecurity.com>
Subject: Re: [PATCH v2] use %pK for /proc/kallsyms and /proc/modules
Date: Fri, 04 Feb 2011 14:34:24 -0800 [thread overview]
Message-ID: <1296858864.4133.43.camel@Joe-Laptop> (raw)
In-Reply-To: <20110204142147.006bf978.akpm@linux-foundation.org>
On Fri, 2011-02-04 at 14:21 -0800, Andrew Morton wrote:
> On Fri, 4 Feb 2011 14:09:44 -0800
> Kees Cook <kees.cook@canonical.com> wrote:
> > On Fri, Feb 04, 2011 at 02:03:51PM -0800, Andrew Morton wrote:
> > > kernel/kallsyms.c:481: warning: format '%p' expects type 'void *', but argument 3 has type 'long unsigned int'
> > > I'm struggling to see how this could have been compile-time or runtime
> > > tested?
> > I run-time tested it plenty. The thread contains the various discussions
> > about compile-time warnings, so I suspect in the last version, I didn't go
> > examine the warnings (since the origin of the other warnings went away).
> It's passing `unsigned long kallsym_iter.value' into vsprintf as a
> pointer. Won't vsprintf end up dereferenceing that unsigned long?
No it won't. %p and %pK output the pointer value.
> > I can send a patch to fix it up to cast everything to (void*) if you want?
> No typecasts, please. Get the types *correct* and they won't be needed.
There are many printk casts of longs to void *.
grep -rP --include=*.[ch] "\b(printk|pr_*[a-z]+).*\".*\(void \*\)" *
Typecast is the right way to fix this warning using %pK,
though there might be a different/better way altogether.
prev parent reply other threads:[~2011-02-04 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 0:41 [PATCH v2] use %pK for /proc/kallsyms and /proc/modules Kees Cook
2011-02-04 22:03 ` Andrew Morton
2011-02-04 22:09 ` Kees Cook
2011-02-04 22:21 ` Andrew Morton
2011-02-04 22:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296858864.4133.43.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=drosenberg@vsecurity.com \
--cc=eugeneteo@kernel.org \
--cc=jason.wessel@windriver.com \
--cc=kees.cook@canonical.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.