All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 01/14] qcow2: Really use cache=unsafe for image creation
Date: Mon,  7 Feb 2011 13:40:17 +0100	[thread overview]
Message-ID: <1297082430-628-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1297082430-628-1-git-send-email-kwolf@redhat.com>

For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some
strange unsafe writethrough mode.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 block/qcow2.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index dbe4fdd..a1773e4 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -975,7 +975,8 @@ static int qcow2_create2(const char *filename, int64_t total_size,
      */
     BlockDriver* drv = bdrv_find_format("qcow2");
     assert(drv != NULL);
-    ret = bdrv_open(bs, filename, BDRV_O_RDWR | BDRV_O_NO_FLUSH, drv);
+    ret = bdrv_open(bs, filename,
+        BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, drv);
     if (ret < 0) {
         goto out;
     }
-- 
1.7.2.3

  reply	other threads:[~2011-02-07 12:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 12:40 [Qemu-devel] [PULL 00/14] Block patches for master Kevin Wolf
2011-02-07 12:40 ` Kevin Wolf [this message]
2011-02-07 12:40 ` [Qemu-devel] [PATCH 02/14] Documentation: add Sheepdog disk images Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 04/14] ahci: split ICH9 from core Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 05/14] ahci: add license header in ahci.h Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 06/14] ahci: split ICH and AHCI even more Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 07/14] ahci: send init d2h fis on fis enable Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 08/14] ahci: Implement HBA reset Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 09/14] ahci: make number of ports runtime determined Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 10/14] block-migration: actually disable dirty tracking on cleanup Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 11/14] blockdev: add refcount to DriveInfo Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 12/14] block-migration: add reference to target DriveInfo Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 13/14] Add flag to indicate external users to block device Kevin Wolf
2011-02-07 12:40 ` [Qemu-devel] [PATCH 14/14] block: enable in_use flag Kevin Wolf
2011-02-07 13:26 ` [Qemu-devel] Re: [PULL 00/14] Block patches for master Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297082430-628-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.